Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tuples and InOp implementation to EvalEngine #9281

Merged
merged 9 commits into from
Nov 24, 2021
Merged

Add Tuples and InOp implementation to EvalEngine #9281

merged 9 commits into from
Nov 24, 2021

Conversation

GuptaManan100
Copy link
Member

Description

As a long term goal, we want to replace the usage of PlanValue everywhere. To accomplish this change, we need to add an implementation to evalengine.Expr which can store tuples and evaluate them. This PR accomplishes that change. It introduces a new implementation of evalengine.Expr which stores multiple values and also changes the EvalResult struct to be able to store multiple results for intermediate steps.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
test: added testOne to parse_test
081e92d 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: added tuple as an expression and implemented In operator
219db80 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: implemented NotIn operator
deb0fd1 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: added conversion for ValTuple and Nulls
93cf25a 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: added tuple comparison implementation
1c9117d 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: added complex tuple equality tests
9dd34c9 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels Nov 23, 2021
@GuptaManan100
doc: added comments to exported methods
ce95af3 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
chore: move functions to correct places
7061ee3 
Signed-off-by: Manan Gupta <manan@planetscale.com>
vmg
vmg approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I'm confused about collations propagation for comparisons where the right side is a tuple, but that's something I gotta figure out myself in my branch. 👌

@GuptaManan100
test: added additional tests for single value, no value and null values
e29be50 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vmg vmg merged commit a362c1b into vitessio:main Nov 24, 2021
@vmg vmg deleted the evalengine-plan-value branch November 24, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@vmg vmg vmg approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuptaManan100 @vmg @systay @harshit-gangal @frouioui