Multi column vindex support in select statement #9326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ting Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
multi-column-vindex
branch
from
678dea0 to
4563639
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…tEqual opcode Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…tIN opcode, added relevant test Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…olumn vindex values Signed-off-by: Manan Gupta <manan@planetscale.com>
…alues across resovled shards Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…beign = and another with IN clause Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…rom multi column vindex Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…n multi-column vindex to select better plan later from all the ready options Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ndex Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
requested review from
frouioui,
rafael and
systay
as code owners
systay
reviewed
Dec 9, 2021
… argument bind vars Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for multi-column vindex selection in select sql queries.
This only works with Gen4 planner.
Related Issue(s)
Checklist
Deployment Notes