vttablet: Better use of vtprotobuf memory pool #9365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
force-pushed
the
better-pool
branch
from
a73eb2f to
83c4389
Compare
deepthi
added
Component: TabletManager
Component: Query Serving
Type: Performance
release notes
and removed
Component: TabletManager
labels
mattrobenolt
force-pushed
the
better-pool
branch
from
83c4389 to
277d571
Compare
In the previous implementation, the last iteration of the for loop leaves behind an object to get GC'd since it never gets released back to the pool when the function returns. Also should be a minor optimization by re-using the VStreamRowsResponse rather than returning it to the pool each iteration. Signed-off-by: Matt Robenolt <matt@ydekproductions.com>
mattrobenolt
force-pushed
the
better-pool
branch
from
277d571 to
fefa416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation, the last iteration of the for loop
leaves behind an object to get GC'd since it never gets released back to
the pool when the function returns.
Also should be a minor optimization by re-using the VStreamRowsResponse
rather than returning it to the pool each iteration.
Checklist