VEvent: Add Keyspace/Shard properties to proto #9386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
added
Component: VReplication
release notes
Type: Enhancement
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
requested review from
frouioui,
harshit-gangal,
shlomi-noach and
systay
as code owners
mattlord
approved these changes
Dec 15, 2021
5antelope
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Awesome, thanks for working on this @rohit-nayak-ps! 🎉
This would help a lot for the integration with CDC projects like Debezium, I think it might worth mentioning this on vstream documentations if there is any or mention this in the next release.
deepthi
approved these changes
Dec 16, 2021
|
As @sonne5 said we should document this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently not all types of VEvents have the originating Keyspace/Shard defined: they are present in Row and Field events but we also have other special events like Journal, LastPK, Version, VGTID etc where they are not.
This makes it difficult for VStream API consumers to identify the source of some events. This PR adds the Keyspace and Shard attributes to every VEvent.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Related Issue(s)
#9332
Checklist