Add flag to keep routing rules in v2 vrepl workflows #9441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added
Component: VReplication
Type: Enhancement
mattlord
force-pushed
the
vrepl_complete_keep_rr
branch
3 times, most recently
from
c6ec959 to
540b4ae
Compare
mattlord
changed the title
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_complete_keep_rr
branch
from
540b4ae to
90ad0a4
Compare
mattlord
added a commit
to vitessio/website
that referenced
this pull request
Dec 27, 2021
Added in: vitessio/vitess#9441 Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
to vitessio/website
that referenced
this pull request
Dec 27, 2021
Added in: vitessio/vitess#9441 Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
to vitessio/website
that referenced
this pull request
Dec 27, 2021
Added in: vitessio/vitess#9441 Signed-off-by: Matt Lord <mattalord@gmail.com>
|
Revisiting this, and thought to add below as it might be a relevant discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once you've completed a MoveTables e.g., you may want to keep the routing rules around for a while as you find and fix any application code that is still using the old keyspace.
This adds a
-keep_routing_rulesflag to thevtctl MoveTables {Complete,Cancel}commands for the v2 workflows to support this use case.Related Issue(s)
Checklist
Deployment Notes