Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade downgrade tests for reparent #9473

Merged
merged 10 commits into from
Jan 11, 2022
Merged

Add upgrade downgrade tests for reparent #9473

merged 10 commits into from
Jan 11, 2022

Conversation

GuptaManan100
Copy link
Member

Description

Continuation of #9300. Follows the same methodology as described there. This PR adds a workflow for the upgrade-downgrade tests for reparent operations.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
ci: add upgrade downgrade testing for reparent workflow
819be93 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: add correct tag to reparent tests
8f2008b 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: move all the tests for new features into a separate package
3972949 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: update config file to add the new package there
b47968e 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: bug fix in workflow
a789e0f 
Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui
frouioui approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

go/test/endtoend/reparent/newfeaturetest/reparent_test.go Outdated Show resolved Hide resolved
@frouioui frouioui mentioned this pull request Jan 11, 2022
Merged
2 tasks
frouioui and others added 5 commits January 11, 2022 09:12
@frouioui
fix: run upgrade-downgrade's check label only if GHA event is pull_re…
820fd64 
…quest

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@GuptaManan100
test: fix some tests to work with all versions of vtctl
24a74dc 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: split workflow into 2 parts and remove a redundant part
32947ba 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
docs: fix the license year
a31cbbb 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: bug fix in workflow file deleting an extra binary
1176e3e 
Signed-off-by: Manan Gupta <manan@planetscale.com>
deepthi
deepthi approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

@deepthi deepthi merged commit 56e9dd8 into vitessio:main Jan 11, 2022
@deepthi deepthi deleted the upgrade-downgrade-reparent branch January 11, 2022 23:16
@frouioui frouioui mentioned this pull request Jan 25, 2022
Merged
2 tasks
@frouioui frouioui mentioned this pull request Feb 15, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @deepthi @frouioui