[VTAdmin] Update react-scripts, postcss #9493
Conversation
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
notfelineit
added
Component: VTAdmin
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable jest/no-conditional-expect */ | |||
There was a problem hiding this comment.
Instead of updating the test, I decided to use eslint-disable here.
| @@ -86,7 +86,7 @@ describe('Tablets', () => { | |||
| test.each(tests.map(Object.values))( | |||
| '%s', | |||
| (name: string, filter: string, tablets: pb.Tablet[], expected: { [k: string]: unknown }[]) => { | |||
| const result = formatRows(tablets, filter); | |||
| const result = formatRows(tablets, [], filter); | |||
There was a problem hiding this comment.
This fixes a type issue - formatRows expects 3 params.
| @@ -25,17 +25,20 @@ | |||
| "highcharts-react-official": "^3.0.0", | |||
| "history": "^5.0.0", | |||
| "lodash-es": "^4.17.20", | |||
| "postcss": "^7.0.39", | |||
| "postcss": "^8.4.5", | |||
| "postcss-flexbugs-fixes": "^5.0.2", | |||
There was a problem hiding this comment.
These have to be installed manually for postcss ^8 I think.
|
Unless the upgrade to react-scripts brought more restrictive type checking in I would have preferred to see the test changes and lint updates to be spun into a separate review. My intuition is that these started firing with the eslint upgrade though and so that's why they got pulled in here? In any event these all seem safe enough to me. I'm curious about the need to export Light suggestion would be to include a testing section in the PR template -- I'm assuming that you did a round of app builds and did some coarse grain validation passes (app loads, CSS loads as expectd, etc). LGTM 🚢 |
|
@deepthi notified me of a failure in the |
|
@setassociative Indeed, updating react-scripts caused these untouched files to fail eslint CI, so I had to fix them 😄 The same thing happened with |
|
Thanks @frouioui !! |
Description
This PR updates some vulnerable npm packages, namely:
React Scripts
react-script 5.0.0 has added support for tailwindcss. Followed the steps outlined here: facebook/create-react-app#11717 (comment) to make current version compatible. That includes manually installing necessary postcss plugins.
There are also postcss config updates as suggested here: facebook/create-react-app#11777
Testing
Manual testing was done here, made sure the vtadmin portal rendered "as normal" - primarily the debug page with all the tailwind styles 😃
Related Issue(s)
N/A, run
npm audit fixChecklist
Deployment Notes
None