naming: delete old code that was needed for version compatibility #9516
Conversation
… few other fixes Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
deepthi
added
Component: General
| // For backwards compatibility, we don't require tablet alias to be present in the response | ||
| // TODO(deepthi): After 7.0 change this | ||
| // return br.TransactionId, br.TabletAlias, nil | ||
| // also assert that br.TabletAlias == conn.tablet.Alias |
There was a problem hiding this comment.
Was the scope of this TODO to also assert br.TabletAlias == conn.tablet.Alias.
There was a problem hiding this comment.
I thought that was a good idea at that time, but we don't in general put assertions into production code.
We could put an if condition that returns an error but it seems like overkill.
There was a problem hiding this comment.
@systay @harshit-gangal any opinions on this?
There was a problem hiding this comment.
I think this check is not necessary it is not giving any value here. as the conn here is the actual connection to the server it is unlikely it will differ.
| // For backwards compatibility, we don't require tablet alias to be present in the response | ||
| // TODO(deepthi): After 7.0 change this | ||
| // return br.TransactionId, br.TabletAlias, nil | ||
| // also assert that br.TabletAlias == conn.tablet.Alias |
There was a problem hiding this comment.
I think this check is not necessary it is not giving any value here. as the conn here is the actual connection to the server it is unlikely it will differ.
Description
Delete code that was kept around until we passed v12.0
A few other miscellaneous fixes
Related Issue(s)
#7113
Checklist
Deployment Notes