Remove the Gateway interface
#9852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
added
Type: Enhancement
frouioui
requested review from
harshit-gangal,
systay and
deepthi
as code owners
6 tasks
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
remove-gateway-interface
branch
from
60470e7 to
3f53772
Compare
deepthi
reviewed
Mar 11, 2022
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
remove-gateway-interface
branch
from
5cbc3d1 to
2a31fad
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…rface Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
reviewed
Mar 23, 2022
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
approved these changes
Mar 30, 2022
Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #9500 we removed the legacy gateway (
DiscoveryGateway), leavingTabletGatewayas the only implementation of thevtgate/Gatewayinterface. The interface is now useless, this pull request removes it, along with the-gateway_implementationflag that was previously used to decide which implementation of the gateway we wanted to use.This pull request is rebased on top of #9500, do not merge until #9500 is merged. Commits d0941b1cd14397dd5df4ea323f208bd58e154cbf and 60470e7df9e3537af1e7c58ceaaf2a8a1442e710 are the last commits to look at.
Related Issue(s)
Checklist