Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix __sq_has_values1 error with PulloutSubquery #9855

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Fix __sq_has_values1 error with PulloutSubquery #9855

merged 2 commits into from
Mar 10, 2022

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Mar 9, 2022 •
edited
Loading

Description

This pull request fixes #9854 by using HasValues arguments instead of the regular Name argument for EXISTS subqueries.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
fix: use HasValues argument for EXISTS subquery instead of Name
72a3164 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
test: addition of an end-to-end test for exists subquery
122272b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Mar 9, 2022
Merged
3 tasks
@systay systay merged commit f6f0ae0 into vitessio:main Mar 10, 2022
@systay systay deleted the fix-9854 branch March 10, 2022 14:00
@frouioui frouioui added Backport This is a backport Backport me! and removed Backport This is a backport labels Mar 10, 2022
@frouioui frouioui mentioned this pull request Mar 10, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: PulloutSubquery has missing bind var __sq_has_values1
2 participants
@frouioui @systay