Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin] custom discovery resolver #9977

Merged
merged 34 commits into from
Apr 4, 2022
Merged

[vtadmin] custom discovery resolver #9977

merged 34 commits into from
Apr 4, 2022

Commits on Apr 4, 2022

  1. More test fixes: 

    1. Register `VtctldServer`, not `VtctlServer`.
2. Abuse `GetKeyspace` to allow the client to inspect the listen
   address of a given server to use in assertions.
3. Building on (2), stop asserting on proxy.host, which will be going
   away>

Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    ca943a6 View commit details
    Browse the repository at this point in the history

  2. Add initial proof-of-concept for custom grpc resolver 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    51028f5 View commit details
    Browse the repository at this point in the history

  3. Add Options for passing through cluster-specific configs to Resolvers 

    Still need to actually add flags for these, but this will make it easier.

Also make some things unexported.

Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d5622ee View commit details
    Browse the repository at this point in the history

  4. tidy imports 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    f048c6e View commit details
    Browse the repository at this point in the history

  5. Better, more structured, logging, beginning vtgate/vtsql support 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    640a1d3 View commit details
    Browse the repository at this point in the history

  6. More documentation, plus unexport our resolver implementation 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b594953 View commit details
    Browse the repository at this point in the history

  7. More docs 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    268d021 View commit details
    Browse the repository at this point in the history

  8. gut WaitForReady 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    34e5684 View commit details
    Browse the repository at this point in the history

  9. Add copyright notice 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2879fa2 View commit details
    Browse the repository at this point in the history

  10. Add unit tests for cluster resolver 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    e609389 View commit details
    Browse the repository at this point in the history

  11. Add wrappers to detect ResolveNow calls and remove Sleep from test 🎉 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    e0455c5 View commit details
    Browse the repository at this point in the history

  12. Document improvement ideas. I'll follow-up on these in a second change 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7c597b0 View commit details
    Browse the repository at this point in the history

  13. Add *Addrs variants of discovery for gates and vtctlds 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    5610bba View commit details
    Browse the repository at this point in the history

  14. Refactors! Better discoveryFunc abstraction and still update addrs wi… 

    …th empty list, and tests

Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    bd09cd9 View commit details
    Browse the repository at this point in the history

  15. Add debug.Debuggable support for resolvers 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7730366 View commit details
    Browse the repository at this point in the history

  16. Use cluster discovery resolver for vtgate/vtsql as well 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7431402 View commit details
    Browse the repository at this point in the history

  17. Fix tests 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    39eecaf View commit details
    Browse the repository at this point in the history

  18. remove waitforready-related flag and config 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    8f296af View commit details
    Browse the repository at this point in the history

  19. post merge cleanup 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    68386e0 View commit details
    Browse the repository at this point in the history

  20. The big refactor to enable configurable resolver options 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    30476f7 View commit details
    Browse the repository at this point in the history

  21. remove unnecssary discovery call 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    00c30d0 View commit details
    Browse the repository at this point in the history

  22. remove WithBlock debugging aid 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b6e838d View commit details
    Browse the repository at this point in the history

  23. rename resolver debug fields for consistency 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    453c0b5 View commit details
    Browse the repository at this point in the history

  24. Push discovery down to resolver level, update tests 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    419bc96 View commit details
    Browse the repository at this point in the history

  25. annotate resolver span with addrs 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2848fe3 View commit details
    Browse the repository at this point in the history

  26. add util function for dial addrs 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3d858b6 View commit details
    Browse the repository at this point in the history

  27. Remove .host field as it does not have a use anymore 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    acbadfa View commit details
    Browse the repository at this point in the history

  28. inline vtsql trace helper 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b2b9dd9 View commit details
    Browse the repository at this point in the history

  29. Support balancer policies 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    bee9bc7 View commit details
    Browse the repository at this point in the history

  30. add link to service config docs 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    c46051e View commit details
    Browse the repository at this point in the history

  31. lol ...... 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    71fe85b View commit details
    Browse the repository at this point in the history

  32. add documentation 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    6efd9d8 View commit details
    Browse the repository at this point in the history

  33. Update code to use new target.URL field (all other fields are depreca… 

    …ted)

Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3d7ab09 View commit details
    Browse the repository at this point in the history

  34. Update tests with URL field 

    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Andrew Mason committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    f1bc355 View commit details
    Browse the repository at this point in the history