Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change instructions for local install #1220

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Change instructions for local install #1220

merged 2 commits into from
Nov 30, 2022

Conversation

rsajwani
Copy link
Collaborator

@rsajwani rsajwani commented Nov 14, 2022

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

There is a a bug in v15.0 where local install fails when it tries to local vtadmin web locally. PR#11683 will fix the issue but we need to reflect these changes in our local install instructions as well. This PR focus on changing the instructions as needed.

Issue#11679

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 42c81e4
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/6386b06f80fd900008e25d67
😎 Deploy Preview https://deploy-preview-1220--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@frouioui frouioui added the do-not-merge PR contains issues or is dependent on another task label Nov 14, 2022
@frouioui frouioui changed the title Change instructiosn for local install Change instructions for local install Nov 15, 2022
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few comments that need to be addressed. Not approving this as we have to wait until we do the v15.0.1 release to merge it.

GuptaManan100
GuptaManan100 previously approved these changes Nov 24, 2022
content/en/docs/15.0/get-started/local.md Outdated Show resolved Hide resolved
@GuptaManan100 GuptaManan100 dismissed their stale review November 24, 2022 04:39

Florent commented not to approve

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@frouioui frouioui merged commit bf0d481 into prod Nov 30, 2022
@frouioui frouioui deleted the v15-vtadmin-fix branch November 30, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge PR contains issues or is dependent on another task
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants