Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VReplication Reference Pages #1267

Merged
merged 17 commits into from
Dec 22, 2022
Merged

Update VReplication Reference Pages #1267

merged 17 commits into from
Dec 22, 2022

Conversation

mattlord
Copy link
Collaborator

@mattlord mattlord commented Nov 30, 2022

Documents: vitessio/vitess#11705 (likely some stragglers to be corrected in follow-ups as we review the full set of docs)

Fixes: #1242

Signed-off-by: Matt Lord <mattalord@gmail.com>
@netlify
Copy link

netlify bot commented Nov 30, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit a8a0eba
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/63a48cef4d4d5f0009d62d5c
😎 Deploy Preview https://deploy-preview-1267--vitess.netlify.app/docs/16.0/reference/vreplication/tablet_selection
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Noticed a few minor issues. Otherwise looks very good.

content/en/docs/16.0/reference/vreplication/metrics.md Outdated Show resolved Hide resolved
content/en/docs/16.0/reference/vreplication/movetables.md Outdated Show resolved Hide resolved
content/en/docs/16.0/reference/vreplication/movetables.md Outdated Show resolved Hide resolved
content/en/docs/16.0/reference/vreplication/reshard.md Outdated Show resolved Hide resolved
@mattlord
Copy link
Collaborator Author

Thanks, @rohit-nayak-ps ! I believe that I addressed your comments here: e02d88c

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord merged commit 58181a8 into prod Dec 22, 2022
@mattlord mattlord deleted the vrepl_reference branch December 22, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs Review] VReplication Reference Pages
3 participants