MoveTables: Document --no-routing-rules #1573
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
We also need to update the vtctldclient docs. You can generate them this way from the website repo:
go run ./tools/vtctldclientdocs/ --vitess-dir ${VTROOT} --version-pairs "rohit/movetables-no-routing-rules-main:18.0"
You'll need to do it for whatever versions we're changing.
There was a problem hiding this comment.
Are we back porting the PR? The PR doesn't have any backport labels ATM.
There was a problem hiding this comment.
(there's also a make target that does this for you)
There was a problem hiding this comment.
Yep! Then you just need to set some env vars (you'll see which if you look at the Makefile).
There was a problem hiding this comment.
Thanks, generated. No, we are not backporting. Documenting now only for v18.
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rohit/movetables-no-routing-rules-main
branch
from
4958651
to
896c3ab
Compare
| @@ -25,6 +25,7 @@ vtctldclient --server localhost:15999 movetables --workflow commerce2customer -- | |||
| --defer-secondary-keys Defer secondary index creation for a table until after it has been copied | |||
| --exclude-tables strings Source tables to exclude from copying | |||
| -h, --help help for create | |||
| --no-routing-rules (Advanced) MoveTables Create only. Do not create routing rules while creating the workflow. See the reference documentation for limitations if you use this flag. | |||
There was a problem hiding this comment.
Hmm, didn't we remove the MoveTables Create only. part in vtctldclient since that is enforced properly in the code?
There was a problem hiding this comment.
Yeah, I thought so too ... Removed locally and regenerated docs.
There was a problem hiding this comment.
Hmm, figured it out. Had accepted the change in the UI but not pulled the changes ...
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Documents flag added in vitessio/vitess#13895