Docs: tablet throttler deprecations in v21
#1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
14 tasks
|
@deepthi for review 🙏 |
deepthi
approved these changes
Aug 27, 2024
|
|
||
| ### Flags | ||
|
|
||
| - The flags `--check-as-check-self` and `--check-as-check-shard` in `vtctldclient UpdateThrottlerConfig`. These flags were useful in the single-metric throttler. The new multi-metric design allows a per app configuration of not only a list of metrics, but also the scope of each metrics. For example, both these commands can be applied: |
There was a problem hiding this comment.
Do we show a deprecation message when people try to use these flags?
There was a problem hiding this comment.
(See vitessio/vitess#16507)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per vitessio/vitess#15624 (comment) and for cleanup purposes, we want to deprecate:
--check-as-check-selfand--check-as-check-shardflags inUpdateThrottlerConfig, see DeprecateUpdateThrottlerConfig's--check-as-check-selfand--check-as-check-shardflags vitess#16507/throttler/...HTTP endpoints, as we move into gRPC-only communication, with the exception of/throttler/checkthat is still being used bygh-ostSHOW VITESS_THROTTLER STATUSandSHOW VITESS_THROTTLED_APPSThere is no way to show the user a deprecation message for the HTTP requests and for the SQL queries, so I believe documentation is the best way to go.