Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MYSQL_FLAVOR requirement #255

Closed
wants to merge 3 commits into from

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Aug 8, 2019

This is no longer required since
vitessio/vitess#4987 merged

This is currently accurate for the build from source and vagrant tutorials, but the local tutorial needs to wait until a new vitess-release is built.

cc @gedgar

Signed-off-by: Morgan Tocker tocker@gmail.com

This is no longer required since
vitessio/vitess#4987 merged

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo added the do-not-merge PR contains issues or is dependent on another task label Aug 8, 2019
@gedgar
Copy link
Collaborator

gedgar commented Aug 12, 2019

@morgo, Running yum install mysql-server yields No package mysql-server available. on a fresh CentOS 7 box. I'm assuming this is because MariaDB 5.5 replaced MySQL in CentOS 7, and MariaDB 10.3 replaces MySQL in RHEL 8. Do we want to update the MySQL installation instructions for RHEL/CentOS?

Maybe something like this?

sudo yum localinstall https://dev.mysql.com/get/mysql57-community-release-el7-9.noarch.rpm
sudo yum install mysql-community-server

Signed-off-by: Morgan Tocker <tocker@gmail.com>
…flavor

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo
Copy link
Contributor Author

morgo commented Aug 13, 2019

Thanks @gedgar - I've changed the yum steps.

The apt steps I've left the same, since they are correct for Ubuntu. But for Debian there is a similar deal, where it is now MariaDB. We could do something like this, but I think I'm going to kick that can down the road, since it is still correct in Ubuntu etc. What do you think?

wget https://dev.mysql.com/get/mysql-apt-config_0.8.13-1_all.deb
sudo apt install -y ./mysql-apt-config_0.8*
sudo sed -i 's/mysql-8.0/mysql-5.7/' /etc/apt/sources.list.d/mysql.list
sudo apt-get update
sudo apt-get install mysql-community-server mysql-community-client

@morgo morgo removed the do-not-merge PR contains issues or is dependent on another task label Oct 8, 2019
@morgo
Copy link
Contributor Author

morgo commented Oct 27, 2019

I will address this in #323 and #309 instead. Closing.

@morgo morgo closed this Oct 27, 2019
@morgo morgo deleted the morgo-remove-mysql-flavor branch October 27, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants