Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vreplication docs: MoveTables and Resharding #415

Merged
merged 13 commits into from
Apr 13, 2020

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 10, 2020

Fixes #334

I incorporated the actual workflow steps here instead of the shell scripts. I like it more because it is more descriptive of the usage and easier to customize. The shell scripts add a level of indirection which makes it harder.

Signed-off-by: Morgan Tocker tocker@gmail.com

@morgo morgo force-pushed the morgo-vreplication-local-examples branch from 0428486 to d7fe3a1 Compare March 10, 2020 20:30
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo force-pushed the morgo-vreplication-local-examples branch from d7fe3a1 to 22fddab Compare March 10, 2020 20:32
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try this out when everything gets checked in and give more updates.

content/en/docs/user-guides/vertical-split.md Outdated Show resolved Hide resolved
content/en/docs/user-guides/horizontal-sharding.md Outdated Show resolved Hide resolved
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo force-pushed the morgo-vreplication-local-examples branch from a10ce5c to 0bde4e4 Compare March 27, 2020 15:48
…local-examples

Signed-off-by: Morgan Tocker <tocker@gmail.com>
…scale/vitess-website into morgo-vreplication-local-examples

Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo changed the title WIP - Vreplication docs Vreplication docs: MoveTables and Resharding Apr 2, 2020
@morgo morgo marked this pull request as ready for review April 2, 2020 14:56
@morgo morgo requested a review from bnlandry April 6, 2020 15:09
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo force-pushed the morgo-vreplication-local-examples branch from 1064089 to d5c7eda Compare April 6, 2020 15:33

As a stepping stone towards horizontally sharding (splitting a single table across multiple servers), it usually makes sense to split from having a single monolithic keyspace (`commerce`) to having multiple keyspaces (`commerce` and `customer`) that match your access pattern. For example, in our ecommerce system we know that `customer` and `corder` tables are closely related and growing at a high rate just by themselves.

Lets start by simulating this situation by loading sample data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall style note: it's often more clear to avoid the first person plural, since it creates ambiguity about who is who. Also, it can be helpful to avoid using the past and present tense, since it causes the user to mentally jump around in the sequence, which can be disorienting in a how-to guide.


The next decision is about the sharding keys, aka Primary Vindexes. This is a complex decision that involves the following considerations:

* What are the highest QPS queries, and what are the where clauses for them?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: ...and what are the WHERE clauses for them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also throughout.

Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Change it again after Vitess 6 release.

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo merged commit aaabb63 into vitessio:prod Apr 13, 2020
@morgo morgo deleted the morgo-vreplication-local-examples branch April 13, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename vertical split to Move Tables
5 participants