Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to remove extra operator file #656

Merged
merged 1 commit into from
Jan 8, 2021
Merged

updating to remove extra operator file #656

merged 1 commit into from
Jan 8, 2021

Conversation

hallaroo
Copy link
Member

@hallaroo hallaroo commented Jan 4, 2021

This PR works in conjunction with #646 to update the Vitess docs to remove the https://github.com/vitessio/vitess/blob/master/examples/operator/select_commerce_data.sql file.

Signed-off-by: hallaroo <marla@planetscale.com>
@hallaroo hallaroo requested a review from askdba January 4, 2021 16:15
@netlify
Copy link

netlify bot commented Jan 4, 2021

Deploy preview for vitess ready!

Built with commit b853647

https://deploy-preview-656--vitess.netlify.app

hallaroo added a commit to vitessio/vitess that referenced this pull request Jan 4, 2021
Once vitessio/website#656 and vitessio/website#646 have been committed to adjust the Vitess docs this file should be removed as it was confirmed to be redundant to https://github.com/vitessio/vitess/blob/master/examples/common/select_commerce_data.sql.
@hallaroo hallaroo self-assigned this Jan 5, 2021
Copy link
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hallaroo hallaroo requested a review from askdba January 7, 2021 16:02
Copy link
Collaborator

@gedgar gedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hallaroo hallaroo merged commit 58c0b44 into prod Jan 8, 2021
@hallaroo hallaroo deleted the mp-commerce-sql branch January 8, 2021 18:17
hallaroo added a commit to vitessio/vitess that referenced this pull request Jan 8, 2021
Once vitessio/website#656 and vitessio/website#646 have been committed to adjust the Vitess docs this file should be removed as it was confirmed to be redundant to https://github.com/vitessio/vitess/blob/master/examples/common/select_commerce_data.sql.

Signed-off-by: hallaroo <marla@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants