Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: revertible migrations, declarative migrations, SQL commands #733

Merged
merged 8 commits into from
Apr 20, 2021

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Mar 25, 2021

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested a review from a team March 25, 2021 15:48
@netlify
Copy link

netlify bot commented Mar 25, 2021

Deploy preview for vitess ready!

Built with commit c01c27f

https://deploy-preview-733--vitess.netlify.app

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

All of the relevant code changes have been merged, and so this doc update should be reviewed and merged as well

@shlomi-noach
Copy link
Contributor Author

This needs to merged for v10 cc @askdba

Copy link
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove references to Aurora/RDS as they aren't the best practice to be used with Vitess.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Can we remove references to Aurora/RDS as they aren't the best practice to be used with Vitess.

Removed!

Copy link
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@askdba askdba merged commit 43bf07b into prod Apr 20, 2021
@askdba askdba deleted the online-ddl-queries-revert-delarative branch April 20, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants