Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Ritwiz's LFX Experience #902

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Blog: Ritwiz's LFX Experience #902

merged 3 commits into from
Dec 10, 2021

Conversation

GuptaManan100
Copy link
Member

This is the blog written by @ritwizsinha on his experience with LFX internship!

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added the blog Adding or editing blog posts label Dec 7, 2021
@netlify
Copy link

netlify bot commented Dec 7, 2021

✔️ Deploy Preview for vitess ready!

🔨 Explore the source changes: 08703df

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/61b17ca2b949550007d67fe2

😎 Browse the preview: https://deploy-preview-902--vitess.netlify.app/blog/2021-12-10-lfx-experience

@GuptaManan100
Copy link
Member Author

This is to be merged on 10th December 2021.

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuptaManan100 @ritwizsinha, this looks really good! I love it. Informative and easy to read 👌🏻🏆

I left three small suggestions that made more sense to my non-English self :)

content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
@frouioui frouioui added the do-not-merge PR contains issues or is dependent on another task label Dec 7, 2021
Copy link
Member

@hallaroo hallaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a number of suggestions to help with grammar and some run on sentences. Please feel free to take or leave the suggestions.

I copied out the full sentence and adjusted it. So whatever changes are liked can just be copied and pasted to replace. Thanks!

content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
content/en/blog/2021-12-10-lfx-experience.md Outdated Show resolved Hide resolved
ritwizsinha and others added 2 commits December 8, 2021 14:18
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Copy link
Member

@hallaroo hallaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@GuptaManan100 GuptaManan100 removed the do-not-merge PR contains issues or is dependent on another task label Dec 10, 2021
@GuptaManan100 GuptaManan100 merged commit 8cc1a45 into prod Dec 10, 2021
@GuptaManan100 GuptaManan100 deleted the blog-lfx-ritwiz branch December 10, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog Adding or editing blog posts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants