Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use valid plugin name in ESLint v8 instructions #525

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

kamilogorek
Copy link
Contributor

Removed incorrecly used @.

@veritem veritem merged commit e66858b into vitest-dev:main Sep 9, 2024
@kamilogorek kamilogorek deleted the patch-1 branch September 9, 2024 13:29
@bruce-c-liu
Copy link

@veritem

I don't think this fix is correct. Things were working with #499, but this breaks it again.

@bruce-c-liu
Copy link

Oh, I see. It's because @kamilogorek was using the "deprecated" eslint-plugin-vitest package instead of the now "official" @vitest/eslint-plugin package.

Related issue: #537

@kamilogorek Please revert this change and use @vitest/eslint-plugin instead. Thanks :)

@kamilogorek
Copy link
Contributor Author

Ah gotcha, can confirm everything works just fine with @vitest/eslint-plugin. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants