Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix typecheck #531

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: fix typecheck #531

merged 1 commit into from
Sep 13, 2024

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Sep 12, 2024

This PR adds:

  • missing MessageIds for rule prefer-lowercase-title
  • missing generic type PluginDoc for utils createEslintRule.

So now npm run tsc won't throw.

veritem
veritem approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@veritem veritem merged commit 2a0bd8e into vitest-dev:main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veritem veritem veritem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntnyq @veritem