fix(vitest): don't hang with maxConcurrency 0

vitest-dev · Oct 3, 2024 · 4da333b · 4da333b
1 parent 46be62c
commit 4da333b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/packages/vitest/src/node/config/resolveConfig.ts b/packages/vitest/src/node/config/resolveConfig.ts
@@ -207,6 +207,13 @@ export function resolveConfig(
     resolved.minWorkers = 1
   }
 
+  if (resolved.maxConcurrency === 0) {
+    logger.console.warn(
+      c.yellow(`The option "maxConcurrency" cannot be set to 0. Using default value ${configDefaults.maxConcurrency} instead.`),
+    )
+    resolved.maxConcurrency = configDefaults.maxConcurrency
+  }
+
   if (resolved.inspect || resolved.inspectBrk) {
     const isSingleThread
       = resolved.pool === 'threads'

diff --git a/test/config/test/failures.test.ts b/test/config/test/failures.test.ts
@@ -279,3 +279,10 @@ test('mergeReports doesn\'t work with watch mode enabled', async () => {
 
   expect(stderr).toMatch('Cannot merge reports with --watch enabled')
 })
+
+test('maxConcurrency 0 prints a warning', async () => {
+  const { stderr, ctx } = await runVitest({ maxConcurrency: 0 })
+
+  expect(ctx?.config.maxConcurrency).toBe(5)
+  expect(stderr).toMatch('The option "maxConcurrency" cannot be set to 0. Using default value 5 instead.')
+})
diff --git a/test/config/vitest.config.ts b/test/config/vitest.config.ts
@@ -19,6 +19,7 @@ export default defineConfig({
       truncateThreshold: 999,
     },
     coverage: {
+      // test that empty reporter does not throw
       reporter: [],
     },
   },