perf: use hash to replace createHash

vitest-dev · Oct 14, 2024 · f5f2ed5 · f5f2ed5
1 parent d260cef
commit f5f2ed5
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 9 deletions.
diff --git a/packages/vitest/src/integrations/css/css-modules.ts b/packages/vitest/src/integrations/css/css-modules.ts
@@ -1,8 +1,8 @@
-import { createHash } from 'node:crypto'
+import { hash } from '../../utils'
 import type { CSSModuleScopeStrategy } from '../../node/types/config'
 
 export function generateCssFilenameHash(filepath: string) {
-  return createHash('md5').update(filepath).digest('hex').slice(0, 6)
+  return hash('md5', filepath, 'hex').slice(0, 6)
 }
 
 export function generateScopedClassName(

diff --git a/packages/vitest/src/node/cache/index.ts b/packages/vitest/src/node/cache/index.ts
@@ -1,6 +1,5 @@
-import crypto from 'node:crypto'
 import { resolve } from 'pathe'
-import { slash } from '../../utils'
+import { hash, slash } from '../../utils'
 import { FilesStatsCache } from './files'
 import { ResultsCache } from './results'
 
@@ -26,7 +25,7 @@ export class VitestCache {
       ? resolve(
         root,
         baseDir,
-        crypto.createHash('md5').update(projectName, 'utf-8').digest('hex'),
+        hash('md5', projectName, 'hex'),
       )
       : resolve(root, baseDir)
   }

diff --git a/packages/vitest/src/node/pools/rpc.ts b/packages/vitest/src/node/pools/rpc.ts
@@ -1,9 +1,9 @@
-import { createHash } from 'node:crypto'
 import { mkdir, writeFile } from 'node:fs/promises'
 import type { RawSourceMap } from 'vite-node'
 import { join } from 'pathe'
 import type { WorkspaceProject } from '../workspace'
 import type { RuntimeRPC } from '../../types/rpc'
+import { hash } from '../../utils'
 
 const created = new Set()
 const promises = new Map<string, Promise<void>>()
@@ -47,7 +47,7 @@ export function createMethodsRPC(project: WorkspaceProject, options: MethodsOpti
       }
 
       const dir = join(project.tmpDir, transformMode)
-      const name = createHash('sha1').update(id).digest('hex')
+      const name = hash('sha1', id, 'hex')
       const tmp = join(dir, name)
       if (promises.has(tmp)) {
         await promises.get(tmp)

diff --git a/packages/vitest/src/node/sequencers/BaseSequencer.ts b/packages/vitest/src/node/sequencers/BaseSequencer.ts
@@ -1,6 +1,6 @@
-import { createHash } from 'node:crypto'
 import { relative, resolve } from 'pathe'
 import { slash } from 'vite-node/utils'
+import { hash } from '../../utils'
 import type { Vitest } from '../core'
 import type { WorkspaceSpec } from '../pool'
 import type { TestSequencer } from './types'
@@ -25,7 +25,7 @@ export class BaseSequencer implements TestSequencer {
         const specPath = fullPath?.slice(config.root.length)
         return {
           spec,
-          hash: createHash('sha1').update(specPath).digest('hex'),
+          hash: hash('sha1', specPath, 'hex'),
         }
       })
       .sort((a, b) => (a.hash < b.hash ? -1 : a.hash > b.hash ? 1 : 0))

diff --git a/packages/vitest/src/utils/index.ts b/packages/vitest/src/utils/index.ts
@@ -1,3 +1,4 @@
+import crypto from 'node:crypto'
 import { relative } from 'pathe'
 import { getWorkerState } from '../utils'
 
@@ -54,3 +55,9 @@ export function objectAttr(
   }
   return result
 }
+
+export const hash = crypto.hash ?? ((
+  algorithm: string,
+  data: crypto.BinaryLike,
+  outputEncoding: crypto.BinaryToTextEncoding,
+) => crypto.createHash(algorithm).update(data).digest(outputEncoding))