fix(cli): Don't override config by setting cli options to undefined #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been introduced by vitest-dev#2180. The change there will *always* set argv.dir, no matter if it's been there before or not. When it's not there, it will set it to undefined, which then will lead to vitest using the root as fallback instead of the config set in the config file, since CLI options override config options. In our case, this config was essentially ignored since 0.24.4. ```js import { defineConfig } from "vite" export default defineConfig({ test: { dir: "spec/javascript" } }) ``` with the only workaround of providing `dir` via CLI option.
|
Reproduction to test: https://stackblitz.com/edit/node-lrwnma?file=vite.config.js Thanks for looking into this :) |
sheremet-va
approved these changes
Nov 21, 2022
renovate bot
referenced
this pull request
in Unleash/unleash
Nov 22, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.25.2` -> `0.25.3`](https://renovatebot.com/diffs/npm/vitest/0.25.2/0.25.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.25.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) ##### 🚀 Features - Test.each support string template - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2337](https://togithub.com/vitest-dev/vitest/issues/2337) [<samp>(f7897)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7897765) ##### 🐞 Bug Fixes - Junit consistently puts "skipped" inside "testcase" - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(f7b27)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7b27af0) - Detect tests in folders starting with `.` - by [@​sidharthv96](https://togithub.com/sidharthv96) in [https://github.com/vitest-dev/vitest/issues/2344](https://togithub.com/vitest-dev/vitest/issues/2344) and [https://github.com/vitest-dev/vitest/issues/2359](https://togithub.com/vitest-dev/vitest/issues/2359) [<samp>(c3951)</samp>](https://togithub.com/vitest-dev/vitest/commit/c395177f) - **cli**: Don't override config by setting cli options to undefined - by [@​rmehner](https://togithub.com/rmehner) in [https://github.com/vitest-dev/vitest/issues/2330](https://togithub.com/vitest-dev/vitest/issues/2330) [<samp>(6ce3e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ce3ed7f) - **coverage**: Env-replacer to add filenames into sourcemaps - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2338](https://togithub.com/vitest-dev/vitest/issues/2338) [<samp>(a2e9d)</samp>](https://togithub.com/vitest-dev/vitest/commit/a2e9daf6) - **mocker**: Clear automocked modules on unmock - by [@​mcous](https://togithub.com/mcous) in [https://github.com/vitest-dev/vitest/issues/2353](https://togithub.com/vitest-dev/vitest/issues/2353) [<samp>(60918)</samp>](https://togithub.com/vitest-dev/vitest/commit/609185bd) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC4yIiwidXBkYXRlZEluVmVyIjoiMzQuMzAuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
fwouts
referenced
this pull request
in fwouts/previewjs
Nov 23, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.25.2` -> `0.25.3`](https://renovatebot.com/diffs/npm/vitest/0.25.2/0.25.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.25.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) ##### 🚀 Features - Test.each support string template - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2337](https://togithub.com/vitest-dev/vitest/issues/2337) [<samp>(f7897)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7897765) ##### 🐞 Bug Fixes - Junit consistently puts "skipped" inside "testcase" - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(f7b27)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7b27af0) - Detect tests in folders starting with `.` - by [@​sidharthv96](https://togithub.com/sidharthv96) in [https://github.com/vitest-dev/vitest/issues/2344](https://togithub.com/vitest-dev/vitest/issues/2344) and [https://github.com/vitest-dev/vitest/issues/2359](https://togithub.com/vitest-dev/vitest/issues/2359) [<samp>(c3951)</samp>](https://togithub.com/vitest-dev/vitest/commit/c395177f) - **cli**: Don't override config by setting cli options to undefined - by [@​rmehner](https://togithub.com/rmehner) in [https://github.com/vitest-dev/vitest/issues/2330](https://togithub.com/vitest-dev/vitest/issues/2330) [<samp>(6ce3e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ce3ed7f) - **coverage**: Env-replacer to add filenames into sourcemaps - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2338](https://togithub.com/vitest-dev/vitest/issues/2338) [<samp>(a2e9d)</samp>](https://togithub.com/vitest-dev/vitest/commit/a2e9daf6) - **mocker**: Clear automocked modules on unmock - by [@​mcous](https://togithub.com/mcous) in [https://github.com/vitest-dev/vitest/issues/2353](https://togithub.com/vitest-dev/vitest/issues/2353) [<samp>(60918)</samp>](https://togithub.com/vitest-dev/vitest/commit/609185bd) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuMzAuNCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
andipaetzold
referenced
this pull request
in andipaetzold/react-firehooks
Nov 25, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/coverage-c8](https://togithub.com/vitest-dev/vitest) | [`0.24.3` -> `0.25.3`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-c8/0.24.3/0.25.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.24.3` -> `0.25.3`](https://renovatebot.com/diffs/npm/vitest/0.24.3/0.25.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.25.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) ##### 🚀 Features - Test.each support string template - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2337](https://togithub.com/vitest-dev/vitest/issues/2337) [<samp>(f7897)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7897765) ##### 🐞 Bug Fixes - Junit consistently puts "skipped" inside "testcase" - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(f7b27)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7b27af0) - Detect tests in folders starting with `.` - by [@​sidharthv96](https://togithub.com/sidharthv96) in [https://github.com/vitest-dev/vitest/issues/2344](https://togithub.com/vitest-dev/vitest/issues/2344) and [https://github.com/vitest-dev/vitest/issues/2359](https://togithub.com/vitest-dev/vitest/issues/2359) [<samp>(c3951)</samp>](https://togithub.com/vitest-dev/vitest/commit/c395177f) - **cli**: Don't override config by setting cli options to undefined - by [@​rmehner](https://togithub.com/rmehner) in [https://github.com/vitest-dev/vitest/issues/2330](https://togithub.com/vitest-dev/vitest/issues/2330) [<samp>(6ce3e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ce3ed7f) - **coverage**: Env-replacer to add filenames into sourcemaps - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2338](https://togithub.com/vitest-dev/vitest/issues/2338) [<samp>(a2e9d)</samp>](https://togithub.com/vitest-dev/vitest/commit/a2e9daf6) - **mocker**: Clear automocked modules on unmock - by [@​mcous](https://togithub.com/mcous) in [https://github.com/vitest-dev/vitest/issues/2353](https://togithub.com/vitest-dev/vitest/issues/2353) [<samp>(60918)</samp>](https://togithub.com/vitest-dev/vitest/commit/609185bd) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) ### [`v0.25.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.1...v0.25.2) ##### 🐞 Bug Fixes - Dates are equal, if both are invalid - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2326](https://togithub.com/vitest-dev/vitest/issues/2326) - Don't ignore properties, when put on a default function in CJS context - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2325](https://togithub.com/vitest-dev/vitest/issues/2325) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.1...v0.25.2) ### [`v0.25.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.0...v0.25.1) ##### 🚀 Features - Add `vi.setConfig` helper - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2293](https://togithub.com/vitest-dev/vitest/issues/2293) - Allow hooks to be executed in a stack or list - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2294](https://togithub.com/vitest-dev/vitest/issues/2294) ##### 🐞 Bug Fixes - Always rewrite defined jsdom keys - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2290](https://togithub.com/vitest-dev/vitest/issues/2290) - Default reporter regression - by [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2292](https://togithub.com/vitest-dev/vitest/issues/2292) - Don't fail `bench` when using options - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2295](https://togithub.com/vitest-dev/vitest/issues/2295) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.0...v0.25.1) ### [`v0.25.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.5...v0.25.0) ##### ✅ Builtin TypeChecking In v0.25.0, Vitest allows you to write tests for your types, using `expectTypeOf` or `assertType` syntaxes. By default all tests inside `*.test-d.ts` files are considered type tests. Run `vitest typecheck` to run type tests. ```ts // my.test-d.ts import { assertType, expectTypeOf } from 'vitest' import { mount } from './mount.js' test('my types work properly', () => { expectTypeOf(mount).toBeFunction() expectTypeOf(mount).parameter(0).toMatchTypeOf<{ name: string }>() // @​ts-expect-error name is a string assertType(mount({ name: 42 })) }) ``` Learn more at [the documentation](https://vitest.dev/guide/testing-types.html) and this [RFC](https://togithub.com/vitest-dev/vitest/issues/1954) ##### 🚨 Breaking Changes - Return context in `startVitest()` - by [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2072](https://togithub.com/vitest-dev/vitest/issues/2072) ##### 🚀 Features - `onTestFailed` hook - by [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2210](https://togithub.com/vitest-dev/vitest/issues/2210) - Display error frame if present (like Vite) - by [@​haikyuu](https://togithub.com/haikyuu) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2257](https://togithub.com/vitest-dev/vitest/issues/2257) - Benchmark table report - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2179](https://togithub.com/vitest-dev/vitest/issues/2179) - Add typechecking functionality - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2107](https://togithub.com/vitest-dev/vitest/issues/2107) ##### 🐞 Bug Fixes - Clear full screen only in watch mode - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(c3d89)</samp>](https://togithub.com/vitest-dev/vitest/commit/c3d89504) - Don't serialize symbols and immutables - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2266](https://togithub.com/vitest-dev/vitest/issues/2266) - Use --conditions instead of -C - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2267](https://togithub.com/vitest-dev/vitest/issues/2267) - Show correct stack trace in errors and console - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2248](https://togithub.com/vitest-dev/vitest/issues/2248) - Align `.each` behavior with jest - by [@​bartoszgolebiowski](https://togithub.com/bartoszgolebiowski) and [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2064](https://togithub.com/vitest-dev/vitest/issues/2064) - Remove undefined values in options - by [@​g4rry420](https://togithub.com/g4rry420) and [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2281](https://togithub.com/vitest-dev/vitest/issues/2281) - **coverage**: Istanbul provider to preserve implicit else - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2275](https://togithub.com/vitest-dev/vitest/issues/2275) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.5...v0.25.0) ### [`v0.24.5`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.5) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.4...v0.24.5) ##### 🚀 Features - **vite-node**: Trigger beforeFullReload / beforePrune / invalidate hook - by [@​ycmjason](https://togithub.com/ycmjason) in [https://github.com/vitest-dev/vitest/issues/2079](https://togithub.com/vitest-dev/vitest/issues/2079) ##### 🐞 Bug Fixes - Respect folders with dot at the start, when mocking - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2244](https://togithub.com/vitest-dev/vitest/issues/2244) - Prevent using mocks in rpc - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2254](https://togithub.com/vitest-dev/vitest/issues/2254) - Show actual unhandled errors, serialize DOMErrors - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2253](https://togithub.com/vitest-dev/vitest/issues/2253) - Load deps reporter - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2249](https://togithub.com/vitest-dev/vitest/issues/2249) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.4...v0.24.5) ### [`v0.24.4`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.4) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) ##### 🚀 Features - **vite-node**: Don't exit on uncaughtException in watch mode - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2186](https://togithub.com/vitest-dev/vitest/issues/2186) ##### 🐞 Bug Fixes - Add/Update `repository` properties in `package.json` - by [@​silverwind](https://togithub.com/silverwind) in [https://github.com/vitest-dev/vitest/issues/2151](https://togithub.com/vitest-dev/vitest/issues/2151) - Ignore benchmark.reporters in getSerializableConfig - by [@​kainstar](https://togithub.com/kainstar) in [https://github.com/vitest-dev/vitest/issues/2164](https://togithub.com/vitest-dev/vitest/issues/2164) - Improve config's default exclude - by [@​haikyuu](https://togithub.com/haikyuu) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2188](https://togithub.com/vitest-dev/vitest/issues/2188) - Always use node condition - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/1919](https://togithub.com/vitest-dev/vitest/issues/1919) - Clear terminal output before running tests, show errors in correct order - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2228](https://togithub.com/vitest-dev/vitest/issues/2228) - Improve compatibility with native Node CJS resolution - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2226](https://togithub.com/vitest-dev/vitest/issues/2226) - Don't use resolved paths if they don't actually exist - by [@​simon-abbott](https://togithub.com/simon-abbott) in [https://github.com/vitest-dev/vitest/issues/1868](https://togithub.com/vitest-dev/vitest/issues/1868) - **cli**: - Set inputNamePattern to RegExp source instead of string - by [@​rafedramzi](https://togithub.com/rafedramzi) in [https://github.com/vitest-dev/vitest/issues/2201](https://togithub.com/vitest-dev/vitest/issues/2201) - Normalize argument path - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2180](https://togithub.com/vitest-dev/vitest/issues/2180) - **coverage**: - Trim URL parameters from file paths in istanbul coverage - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2232](https://togithub.com/vitest-dev/vitest/issues/2232) - Trim URL parameters from file paths in c8 coverage - by [@​OrestHk](https://togithub.com/OrestHk) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2181](https://togithub.com/vitest-dev/vitest/issues/2181) - **reporter**: - Load custom reporter using `executeFile` - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2184](https://togithub.com/vitest-dev/vitest/issues/2184) - **vitest**: - Return detailed error when using toHaveReturnedWith - by [@​azaleta](https://togithub.com/azaleta) in [https://github.com/vitest-dev/vitest/issues/2163](https://togithub.com/vitest-dev/vitest/issues/2163) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/andipaetzold/react-firehooks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC4zMC4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot
referenced
this pull request
in mheob/changeset-changelog
Dec 9, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@commitlint/cli](https://commitlint.js.org/) ([source](https://togithub.com/conventional-changelog/commitlint)) | [`^17.2.0` -> `^17.3.0`](https://renovatebot.com/diffs/npm/@commitlint%2fcli/17.2.0/17.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@commitlint/config-conventional](https://commitlint.js.org/) ([source](https://togithub.com/conventional-changelog/commitlint)) | [`^17.2.0` -> `^17.3.0`](https://renovatebot.com/diffs/npm/@commitlint%2fconfig-conventional/17.2.0/17.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^18.11.9` -> `^18.11.11`](https://renovatebot.com/diffs/npm/@types%2fnode/18.11.9/18.11.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@vitest/coverage-istanbul](https://togithub.com/vitest-dev/vitest) | [`^0.25.2` -> `^0.25.4`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-istanbul/0.25.2/0.25.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint](https://eslint.org) ([source](https://togithub.com/eslint/eslint)) | [`^8.28.0` -> `^8.29.0`](https://renovatebot.com/diffs/npm/eslint/8.28.0/8.29.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [lint-staged](https://togithub.com/okonet/lint-staged) | [`^13.0.3` -> `^13.1.0`](https://renovatebot.com/diffs/npm/lint-staged/13.0.3/13.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vite](https://togithub.com/vitejs/vite/tree/main/#readme) ([source](https://togithub.com/vitejs/vite)) | [`^3.2.4` -> `^3.2.5`](https://renovatebot.com/diffs/npm/vite/3.2.4/3.2.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vitest](https://togithub.com/vitest-dev/vitest) | [`^0.25.2` -> `^0.25.4`](https://renovatebot.com/diffs/npm/vitest/0.25.2/0.25.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>conventional-changelog/commitlint (@​commitlint/cli)</summary> ### [`v17.3.0`](https://togithub.com/conventional-changelog/commitlint/blob/HEAD/@​commitlint/cli/CHANGELOG.md#​1730-httpsgithubcomconventional-changelogcommitlintcomparev1721v1730-2022-11-21) [Compare Source](https://togithub.com/conventional-changelog/commitlint/compare/v17.2.0...v17.3.0) **Note:** Version bump only for package [@​commitlint/cli](https://togithub.com/commitlint/cli) </details> <details> <summary>conventional-changelog/commitlint (@​commitlint/config-conventional)</summary> ### [`v17.3.0`](https://togithub.com/conventional-changelog/commitlint/blob/HEAD/@​commitlint/config-conventional/CHANGELOG.md#​1730-httpsgithubcomconventional-changelogcommitlintcomparev1721v1730-2022-11-21) [Compare Source](https://togithub.com/conventional-changelog/commitlint/compare/v17.2.0...v17.3.0) **Note:** Version bump only for package [@​commitlint/config-conventional](https://togithub.com/commitlint/config-conventional) </details> <details> <summary>vitest-dev/vitest</summary> ### [`v0.25.4`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.4) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.3...v0.25.4) ##### 🚀 Features - Slow test threshold - by [@​poyoho](https://togithub.com/poyoho) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2396](https://togithub.com/vitest-dev/vitest/issues/2396) [<samp>(98974)</samp>](https://togithub.com/vitest-dev/vitest/commit/98974ba4) - Format test tablename - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2405](https://togithub.com/vitest-dev/vitest/issues/2405) [<samp>(45c5c)</samp>](https://togithub.com/vitest-dev/vitest/commit/45c5c45a) - Suspend process - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2422](https://togithub.com/vitest-dev/vitest/issues/2422) [<samp>(b8ee8)</samp>](https://togithub.com/vitest-dev/vitest/commit/b8ee821c) - Format test objects in `each` title - by [@​scarf005](https://togithub.com/scarf005) in [https://github.com/vitest-dev/vitest/issues/2420](https://togithub.com/vitest-dev/vitest/issues/2420) and [https://github.com/vitest-dev/vitest/issues/2421](https://togithub.com/vitest-dev/vitest/issues/2421) [<samp>(1868f)</samp>](https://togithub.com/vitest-dev/vitest/commit/1868f1c4) ##### 🐞 Bug Fixes - Exit with code 1, when type tests fail - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2378](https://togithub.com/vitest-dev/vitest/issues/2378) [<samp>(98141)</samp>](https://togithub.com/vitest-dev/vitest/commit/9814124e) - Tab affect vi.mock - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2402](https://togithub.com/vitest-dev/vitest/issues/2402) [<samp>(5a3de)</samp>](https://togithub.com/vitest-dev/vitest/commit/5a3deba5) - Don't escape "\\" in diff view - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2430](https://togithub.com/vitest-dev/vitest/issues/2430) [<samp>(7d4e3)</samp>](https://togithub.com/vitest-dev/vitest/commit/7d4e3ed0) - Correct test files status in json reporter - by [@​brzezinskimarcin](https://togithub.com/brzezinskimarcin) in [https://github.com/vitest-dev/vitest/issues/2417](https://togithub.com/vitest-dev/vitest/issues/2417) and [https://github.com/vitest-dev/vitest/issues/2419](https://togithub.com/vitest-dev/vitest/issues/2419) [<samp>(ce931)</samp>](https://togithub.com/vitest-dev/vitest/commit/ce931956) - Export all named CJS exports, if default export is a function - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2435](https://togithub.com/vitest-dev/vitest/issues/2435) [<samp>(d43f3)</samp>](https://togithub.com/vitest-dev/vitest/commit/d43f3f5c) - Add test attributes to "testsuites" in junit reporter - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2362](https://togithub.com/vitest-dev/vitest/issues/2362) [<samp>(d0506)</samp>](https://togithub.com/vitest-dev/vitest/commit/d050604f) - DynamicImportSettled also waits for nested imports - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2389](https://togithub.com/vitest-dev/vitest/issues/2389) [<samp>(5098b)</samp>](https://togithub.com/vitest-dev/vitest/commit/5098b217) - Always apply vite ssr source maps - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2433](https://togithub.com/vitest-dev/vitest/issues/2433) [<samp>(cbf91)</samp>](https://togithub.com/vitest-dev/vitest/commit/cbf91ba7) - Copy-pasting from module graph browser - by [@​g4rry420](https://togithub.com/g4rry420) in [https://github.com/vitest-dev/vitest/issues/2321](https://togithub.com/vitest-dev/vitest/issues/2321) [<samp>(8920a)</samp>](https://togithub.com/vitest-dev/vitest/commit/8920aa45) - **deps**: Update dependency strip-literal to v1 - by [@​renovate](https://togithub.com/renovate)\[bot] in[https://github.com/vitest-dev/vitest/issues/2387](https://togithub.com/vitest-dev/vitest/issues/2387)7 [<samp>(824e1)</samp>](https://togithub.com/vitest-dev/vitest/commit/824e18c3) - **mocker**: Set cache before mocking to allow circular dependencies - by [@​danez](https://togithub.com/danez) in [https://github.com/vitest-dev/vitest/issues/2391](https://togithub.com/vitest-dev/vitest/issues/2391) [<samp>(fd829)</samp>](https://togithub.com/vitest-dev/vitest/commit/fd8292ac) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.3...v0.25.4) ### [`v0.25.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) ##### 🚀 Features - Test.each support string template - by [@​poyoho](https://togithub.com/poyoho) in [https://github.com/vitest-dev/vitest/issues/2337](https://togithub.com/vitest-dev/vitest/issues/2337) [<samp>(f7897)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7897765) ##### 🐞 Bug Fixes - Junit consistently puts "skipped" inside "testcase" - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(f7b27)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7b27af0) - Detect tests in folders starting with `.` - by [@​sidharthv96](https://togithub.com/sidharthv96) in [https://github.com/vitest-dev/vitest/issues/2344](https://togithub.com/vitest-dev/vitest/issues/2344) and [https://github.com/vitest-dev/vitest/issues/2359](https://togithub.com/vitest-dev/vitest/issues/2359) [<samp>(c3951)</samp>](https://togithub.com/vitest-dev/vitest/commit/c395177f) - **cli**: Don't override config by setting cli options to undefined - by [@​rmehner](https://togithub.com/rmehner) in [https://github.com/vitest-dev/vitest/issues/2330](https://togithub.com/vitest-dev/vitest/issues/2330) [<samp>(6ce3e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ce3ed7f) - **coverage**: Env-replacer to add filenames into sourcemaps - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2338](https://togithub.com/vitest-dev/vitest/issues/2338) [<samp>(a2e9d)</samp>](https://togithub.com/vitest-dev/vitest/commit/a2e9daf6) - **mocker**: Clear automocked modules on unmock - by [@​mcous](https://togithub.com/mcous) in [https://github.com/vitest-dev/vitest/issues/2353](https://togithub.com/vitest-dev/vitest/issues/2353) [<samp>(60918)</samp>](https://togithub.com/vitest-dev/vitest/commit/609185bd) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) </details> <details> <summary>eslint/eslint</summary> ### [`v8.29.0`](https://togithub.com/eslint/eslint/releases/tag/v8.29.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.28.0...v8.29.0) ##### Features - [`49a07c5`](https://togithub.com/eslint/eslint/commit/49a07c52c5af7e98d161ff4acd44bbbe0aa6383b) feat: add `allowParensAfterCommentPattern` option to no-extra-parens ([#​16561](https://togithub.com/eslint/eslint/issues/16561)) (Nitin Kumar) - [`e6a865d`](https://togithub.com/eslint/eslint/commit/e6a865d70aed9e1c07be712e40c38da1a5dda849) feat: `prefer-named-capture-group` add suggestions ([#​16544](https://togithub.com/eslint/eslint/issues/16544)) (Josh Goldberg) - [`a91332b`](https://togithub.com/eslint/eslint/commit/a91332b8bd9adfa2aa8110071bdf73f56d400050) feat: In no-invalid-regexp validate flags also for non-literal patterns ([#​16583](https://togithub.com/eslint/eslint/issues/16583)) (trosos) ##### Documentation - [`0311d81`](https://togithub.com/eslint/eslint/commit/0311d81834d675b8ae7cc92a460b37115edc4018) docs: Configuring Plugins page intro, page tweaks, and rename ([#​16534](https://togithub.com/eslint/eslint/issues/16534)) (Ben Perlmutter) - [`57089b1`](https://togithub.com/eslint/eslint/commit/57089b1ede624452bc94404b6e60d01d48cfd468) docs: add a property assignment example for camelcase rule ([#​16605](https://togithub.com/eslint/eslint/issues/16605)) (Milos Djermanovic) - [`b6ab030`](https://togithub.com/eslint/eslint/commit/b6ab030897d2e8b314b33a6502346a4ac45bb8da) docs: add docs codeowners ([#​16601](https://togithub.com/eslint/eslint/issues/16601)) (Strek) - [`6380c87`](https://togithub.com/eslint/eslint/commit/6380c87c563be5dc78ce0ddd5c7409aaf71692bb) docs: fix sitemap and feed ([#​16592](https://togithub.com/eslint/eslint/issues/16592)) (Milos Djermanovic) - [`ade621d`](https://togithub.com/eslint/eslint/commit/ade621dd12fcd3b65644bb3468248cc040db756c) docs: perf debounce the search query ([#​16586](https://togithub.com/eslint/eslint/issues/16586)) (Shanmughapriyan S) - [`fbcf3ab`](https://togithub.com/eslint/eslint/commit/fbcf3abd54dd20aec3c695cacece56493633c97f) docs: fix searchbar clear button ([#​16585](https://togithub.com/eslint/eslint/issues/16585)) (Shanmughapriyan S) - [`f894035`](https://togithub.com/eslint/eslint/commit/f89403553b31d24f4fc841424cc7dcb8c3ef689f) docs: HTTPS link to yeoman.io ([#​16582](https://togithub.com/eslint/eslint/issues/16582)) (Christian Oliff) - [`de12b26`](https://togithub.com/eslint/eslint/commit/de12b266f2aa6f063d0af888b8f0de41d09ec33f) docs: Update configuration file pages ([#​16509](https://togithub.com/eslint/eslint/issues/16509)) (Ben Perlmutter) - [`1ae9f20`](https://togithub.com/eslint/eslint/commit/1ae9f2067442434c6ccc6b41703624b302d17c67) docs: update correct code examples for `no-extra-parens` rule ([#​16560](https://togithub.com/eslint/eslint/issues/16560)) (Nitin Kumar) ##### Chores - [`7628403`](https://togithub.com/eslint/eslint/commit/7628403a57d9d9b4e2cb2b36309170900f58832e) chore: add discord channel link ([#​16590](https://togithub.com/eslint/eslint/issues/16590)) (Amaresh S M) - [`f5808cb`](https://togithub.com/eslint/eslint/commit/f5808cb51529174a67b4938223f06435ad6d5118) chore: fix rule doc headers check ([#​16564](https://togithub.com/eslint/eslint/issues/16564)) (Milos Djermanovic) </details> <details> <summary>okonet/lint-staged</summary> ### [`v13.1.0`](https://togithub.com/okonet/lint-staged/releases/tag/v13.1.0) [Compare Source](https://togithub.com/okonet/lint-staged/compare/v13.0.4...v13.1.0) ##### Features - expose cli entrance from "lint-staged/bin" ([#​1237](https://togithub.com/okonet/lint-staged/issues/1237)) ([eabf1d2](https://togithub.com/okonet/lint-staged/commit/eabf1d217d8bd2559b1087c92b5ec9b15b8ffa7e)) ### [`v13.0.4`](https://togithub.com/okonet/lint-staged/releases/tag/v13.0.4) [Compare Source](https://togithub.com/okonet/lint-staged/compare/v13.0.3...v13.0.4) ##### Bug Fixes - **deps:** update all dependencies ([336f3b5](https://togithub.com/okonet/lint-staged/commit/336f3b513a8b36579165b2e6fb6e7059b988fe84)) - **deps:** update all dependencies ([ec995e5](https://togithub.com/okonet/lint-staged/commit/ec995e53fb173f2863cb3cc08a92ffa9252dc25d)) </details> <details> <summary>vitejs/vite</summary> ### [`v3.2.5`](https://togithub.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small325-2022-12-05-small) [Compare Source](https://togithub.com/vitejs/vite/compare/v3.2.4...v3.2.5) - chore: cherry pick more v4 bug fixes to v3 ([#​11189](https://togithub.com/vitejs/vite/issues/11189)) ([eba9b42](https://togithub.com/vitejs/vite/commit/eba9b42)), closes [#​11189](https://togithub.com/vitejs/vite/issues/11189) [#​10949](https://togithub.com/vitejs/vite/issues/10949) [#​11056](https://togithub.com/vitejs/vite/issues/11056) [#​8663](https://togithub.com/vitejs/vite/issues/8663) [#​10958](https://togithub.com/vitejs/vite/issues/10958) [#​11120](https://togithub.com/vitejs/vite/issues/11120) [#​11122](https://togithub.com/vitejs/vite/issues/11122) [#​11123](https://togithub.com/vitejs/vite/issues/11123) [#​11132](https://togithub.com/vitejs/vite/issues/11132) - chore: cherry pick v4 bug fix to v3 ([#​11110](https://togithub.com/vitejs/vite/issues/11110)) ([c93a526](https://togithub.com/vitejs/vite/commit/c93a526)), closes [#​11110](https://togithub.com/vitejs/vite/issues/11110) [#​10941](https://togithub.com/vitejs/vite/issues/10941) [#​10987](https://togithub.com/vitejs/vite/issues/10987) [#​10985](https://togithub.com/vitejs/vite/issues/10985) [#​11067](https://togithub.com/vitejs/vite/issues/11067) - fix: relocated logger to respect config. ([#​10787](https://togithub.com/vitejs/vite/issues/10787)) ([#​10967](https://togithub.com/vitejs/vite/issues/10967)) ([bc3b5a9](https://togithub.com/vitejs/vite/commit/bc3b5a9)), closes [#​10787](https://togithub.com/vitejs/vite/issues/10787) [#​10967](https://togithub.com/vitejs/vite/issues/10967) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/mheob/changeset-changelog).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been introduced by #2180. The change there will always set argv.dir, no matter if it's been there before or not. When it's not there, it will set it to undefined, which then will lead to vitest using the root as fallback instead of the config set in the config file, since CLI options override config options.
In our case, this config was essentially ignored since 0.24.4.
with the only workaround of providing
dirvia CLI option.Btw. I'd love to add tests, but I haven't found existing tests for this and didn't have too much time on my hands. Happy to take pointers and add them.