Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: each test case for browser #3100

Merged
merged 7 commits into from
Apr 8, 2023

Conversation

Aslemammad
Copy link
Member

@Aslemammad Aslemammad commented Mar 29, 2023

This tries to resolve issue #3085 since it cannot be reproduced in linux and it works as expected, but adding a test case for more safety!
Resolves #3124

@Aslemammad
Copy link
Member Author

We need to add a browser + windows ci!

test/browser/package.json Outdated Show resolved Hide resolved
@Aslemammad
Copy link
Member Author

The solution for #3124 was that vite didn't allow accessing the dist/utils.js file because of config.fs.strict, so I made it false so the files can be accessed.

@Aslemammad
Copy link
Member Author

For the each case, I tested it in different platforms and it couldn't be reproduced, same with the tests.

@Aslemammad Aslemammad requested a review from sheremet-va April 8, 2023 11:49
@sheremet-va sheremet-va merged commit ddbda10 into vitest-dev:main Apr 8, 2023
@Aslemammad Aslemammad deleted the fix/test-each-browser branch April 8, 2023 11:54
@veaba
Copy link

veaba commented Apr 9, 2023

Not yet fixed on windows.

image

@sheremet-va
Copy link
Member

sheremet-va commented Apr 9, 2023

Not yet fixed on windows.

image

This is why the issue is not closed. And the fix is not yet released.

@veaba
Copy link

veaba commented Apr 9, 2023

Sorry, I thought this PR would fix the problem.

I just clone this repo and use pnpm link to import vitest into my project.

it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser mode hanging on blank white screen, failing to load vitest/utils
3 participants