Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support soft expect #3509

Closed
wants to merge 3 commits into from
Closed

feat: support soft expect #3509

wants to merge 3 commits into from

Conversation

fenghan34
Copy link
Contributor

#3435

Support using soft expect both in test and hooks.

@stackblitz
Copy link

stackblitz bot commented Jun 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sheremet-va
Copy link
Member

sheremet-va commented Jun 4, 2023 •
edited
Loading

Hello! It's interesting that today two different people opened PR for the same feature 😀 But I feel like your runner implementation is too coupled with expect assertion. #3507 direction looks mote like what I envisioned

@fenghan34
Copy link
Contributor Author

Hello! It's interesting that today two different people opened PR for the same feature 😀 But I feel like your runner implementation is too coupled with expect assertion. #3507 direction looks mote like what we need

Aha, just realized that, will close this PR 😂

@fenghan34 fenghan34 closed this Jun 4, 2023
@fenghan34 fenghan34 deleted the feat/soft-expect branch June 5, 2023 00:11
@christian-bromann christian-bromann mentioned this pull request Nov 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fenghan34 @sheremet-va