feat(browser): add support for custom browser capabilities #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
haywirez
force-pushed
the
add-custom-webdriverio-capabilities
branch
2 times, most recently
from
f9bd487
to
d3fa570
Compare
sheremet-va
requested changes
Jul 11, 2023
haywirez
force-pushed
the
add-custom-webdriverio-capabilities
branch
6 times, most recently
from
c9b15da
to
d8b2994
Compare
|
Pushed changed in the spirit of the requested modifications 👍 |
haywirez
changed the title
haywirez
changed the title
dammy001
reviewed
Jul 12, 2023
sheremet-va
requested changes
Jul 12, 2023
haywirez
force-pushed
the
add-custom-webdriverio-capabilities
branch
2 times, most recently
from
9917ccd
to
76ba7fc
Compare
haywirez
force-pushed
the
add-custom-webdriverio-capabilities
branch
2 times, most recently
from
8145b58
to
dfc9894
Compare
haywirez
commented
Jul 13, 2023
packages/vitest/src/types/browser.ts
Outdated
| @@ -2,14 +2,23 @@ import type { Awaitable } from '@vitest/utils' | |||
| import type { WorkspaceProject } from '../node/workspace' | |||
| import type { ApiConfig } from './config' | |||
|
|
|||
| export interface ProviderSpecificOptions { | |||
| webdriverio?: WebDriver.Capabilities | WebDriver.DesiredCapabilities | |||
| playwright?: any | |||
There was a problem hiding this comment.
Couldn't find a good way here to import playwright types only
There was a problem hiding this comment.
I don't think this approach will work, because webdriverio is optional dependency. We shouldn't rely on types
There was a problem hiding this comment.
What would be your preferred way? Would removing added types from package.json and using unknown for both be acceptable?
There was a problem hiding this comment.
Should be acceptable for now
sheremet-va
changed the title
sheremet-va
requested changes
Jul 19, 2023
packages/vitest/src/types/browser.ts
Outdated
| @@ -2,14 +2,23 @@ import type { Awaitable } from '@vitest/utils' | |||
| import type { WorkspaceProject } from '../node/workspace' | |||
| import type { ApiConfig } from './config' | |||
|
|
|||
| export interface ProviderSpecificOptions { | |||
| webdriverio?: WebDriver.Capabilities | WebDriver.DesiredCapabilities | |||
| playwright?: any | |||
There was a problem hiding this comment.
I don't think this approach will work, because webdriverio is optional dependency. We shouldn't rely on types
haywirez
force-pushed
the
add-custom-webdriverio-capabilities
branch
from
dfc9894
to
0ebfedd
Compare
haywirez
force-pushed
the
add-custom-webdriverio-capabilities
branch
from
ebf9469
to
2051f33
Compare
sheremet-va
approved these changes
Aug 14, 2023
sheremet-va
requested changes
Aug 24, 2023
| @@ -57,8 +60,9 @@ export class WebdriverBrowserProvider implements BrowserProvider { | |||
| this.cachedBrowser = await remote({ | |||
| logLevel: 'error', | |||
| capabilities: { | |||
There was a problem hiding this comment.
Why are passing down only capabilities? Shouldn't it be remote options?
|
Will take another look in the coming two weeks |
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to add support for passing custom browser capability arguments for WebdriverIO. This was done rather quickly so improvements and suggestions are welcome, I only saw tests for playwiright.