-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Marko example and include code coverage for Marko files #4263
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fa38f0e
to
7d22f2b
Compare
Rebased, hopefully that's helpful @sheremet-va |
@DylanPiercey Marko example fails when we try to update dependencies in #5123 Do you have any ideas as to why might that be? |
@sheremet-va could you link the failure? Having a hard time finding it |
https://github.com/vitest-dev/vitest/actions/runs/7886477789/job/21519783838?pr=5123 |
Oh nevermind I see it (thanks for the link though). So this is an annoying error that we need to fix on the Marko side but it happens when you've got strange hoisting of Regenerating the lock file and/or ensuring there are no duplicates of |
Ok, I will try that. Thank you. |
@sheremet-va I don't generally use PNPM, but perhaps the dedupe command would do the trick here? |
Looks like it's working, thank you 🙏🏻 |
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.