Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Marko example and include code coverage for Marko files #4263

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Oct 6, 2023

Description

  • Adds Marko to the list of supported frameworks (with an example).
  • Enables code coverage for Marko files by default.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 7d22f2b
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6521521a1899180008d1cc13
😎 Deploy Preview https://deploy-preview-4263--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DylanPiercey
Copy link
Contributor Author

Rebased, hopefully that's helpful @sheremet-va

@sheremet-va sheremet-va merged commit eac7776 into vitest-dev:main Oct 8, 2023
14 of 16 checks passed
@sheremet-va
Copy link
Member

sheremet-va commented Feb 13, 2024

@DylanPiercey Marko example fails when we try to update dependencies in #5123

Do you have any ideas as to why might that be?

@DylanPiercey
Copy link
Contributor Author

@sheremet-va could you link the failure? Having a hard time finding it

@sheremet-va
Copy link
Member

@sheremet-va could you link the failure? Having a hard time finding it

https://github.com/vitest-dev/vitest/actions/runs/7886477789/job/21519783838?pr=5123

@DylanPiercey
Copy link
Contributor Author

DylanPiercey commented Feb 13, 2024

Oh nevermind I see it (thanks for the link though). So this is an annoying error that we need to fix on the Marko side but it happens when you've got strange hoisting of @babel/types (since Marko patches that module to extend babel with Marko's AST nodes).

Regenerating the lock file and/or ensuring there are no duplicates of @babel/types/@babel/traverse will fix it.

@sheremet-va
Copy link
Member

Regenerating the lock file and/or ensuring there are no duplicates of @babel/types/@babel/traverse will fix it.

Ok, I will try that. Thank you.

@DylanPiercey
Copy link
Contributor Author

@sheremet-va I don't generally use PNPM, but perhaps the dedupe command would do the trick here?

@sheremet-va
Copy link
Member

@sheremet-va I don't generally use PNPM, but perhaps the dedupe command would do the trick here?

Looks like it's working, thank you 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants