feat: add expect.addEqualityTesters API #4586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ghiscoding
reviewed
Nov 24, 2023
test/core/test/jest-expect.test.ts
Outdated
| @@ -892,3 +893,87 @@ it('correctly prints diff with asymmetric matchers', () => { | |||
| }) | |||
|
|
|||
| it('timeout', () => new Promise(resolve => setTimeout(resolve, 500))) | |||
|
|
|||
| describe.only('custom equality testers', () => { | |||
There was a problem hiding this comment.
you probably forgot to remove the .only on this one 😉
sheremet-va
requested changes
Nov 27, 2023
…t into feat/jest-custom-testers * 'feat/jest-custom-testers' of github.com:eryue0220/vitest: fix(vitest): correctly support CSS variable when using happy-dom (#4601) fix: date prototype when using setSystemTime (#4584) fix: respect trailing slash when filtering by file path (#4538) docs: correction to configuration parameter (#4587) chore(deps): update dependency @iconify-json/logos to ^1.1.39 (#4596) chore(deps): update dependency @iconify-json/carbon to ^1.1.22 (#4595) chore(deps): update dependency @antfu/ni to ^0.21.10 (#4594) fix(runner): preserve fixtures when calling runif and skipif (fix #4585) (#4591) chore(deps): update dependency @types/jsdom to ^21.1.6 (#4597) fix(vitest): Add import-meta.d.ts (#4571) fix(browser): allow for `pretty-format` as a sibling dependency (#4590)
|
Hi @sheremet-va is there any idea about the CI? It always fails with time out. |
sheremet-va
approved these changes
Dec 4, 2023
sheremet-va
requested changes
Dec 4, 2023
sheremet-va
requested changes
Dec 19, 2023
packages/expect/src/state.ts
Outdated
| ) | ||
| } | ||
|
|
||
| setState({ customTesters: [...testers] }, (globalThis as any)[GLOBAL_EXPECT]) |
There was a problem hiding this comment.
This breaks compatibility with Jest, there it doesn't override testers, but pushes a new one
6 tasks
|
@eryue0220 Could you please take a look at #4880, it is dublicate of this PR but with some differences.
|
Yeah, I've checked the PR, and you're right. I'll close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #4520
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.