Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vm): remove sequencer usage from createVmThreadsPool function (fix #4637) #4638

Merged
merged 2 commits into from
Dec 2, 2023
Merged

fix(vm): remove sequencer usage from createVmThreadsPool function (fix #4637) #4638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5caf4a
fix(vm): remove sequencer usage from createVmThreadsPool function
mhogeveen Dec 1, 2023
90e6f37
chore: return to original formatting
mhogeveen Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/vitest/src/node/pools/vm-threads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ export function createVmThreadsPool(ctx: Vitest, { execArgv, env, vmPath }: Pool
}
}

const Sequencer = ctx.config.sequence.sequencer
const sequencer = new Sequencer(ctx)

return async (specs, invalidates) => {
const configs = new Map<WorkspaceProject, ResolvedConfig>()
const getConfig = (project: WorkspaceProject): ResolvedConfig => {
Expand All @@ -134,13 +131,6 @@ export function createVmThreadsPool(ctx: Vitest, { execArgv, env, vmPath }: Pool
return config
}

const { shard } = ctx.config

if (shard)
specs = await sequencer.shard(specs)

specs = await sequencer.sort(specs)

const filesByEnv = await groupFilesByEnv(specs)
const promises = Object.values(filesByEnv).flat()
const results = await Promise.allSettled(promises
Expand Down