Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make definition clearer in workspace guide #4926

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Metehan-Altuntekin
Copy link
Contributor

@Metehan-Altuntekin Metehan-Altuntekin commented Jan 10, 2024

Description

if you have a folder with your projects named packages is easy to confuse with the actual package name being "packages".

Even though it's not impossible to understand with some thinking, we can make it clearer with this commit.

No testing required, this is just a docs commit.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [ ] Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

*if you have a folder with your projects named `packages`* is easy to confuse with the actual package name being "packages". Even though it's possible to understand with some thinking, we can make it clearer with this commit.
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 329bbb6
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/659eccd9e0eb9c0008f7484f
😎 Deploy Preview https://deploy-preview-4926--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 9ec3f74 into vitest-dev:main Jan 10, 2024
18 of 19 checks passed
@Metehan-Altuntekin Metehan-Altuntekin deleted the patch-1 branch January 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants