-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runner): provide test context to test.each
#4989
Closed
Closed
+343
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
6 tasks
jakebailey
reviewed
Jan 18, 2024
hi-ogawa
commented
Feb 12, 2024
@@ -192,7 +212,6 @@ export interface TestOptions { | |||
} | |||
|
|||
interface ExtendedAPI<ExtraContext> { | |||
each: TestEachFunction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each
in ExtendedAPI
(here) and SuiteAPI
(below) seems to be redundant.
7 tasks
Superseded by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test.each()
#4642I made a few prototypes here in this PR based on the suggestions in the issue.
todo
each7
)test.each5
andtest.each7
getUsedProps
slightly, but it should be simple.(...args, { expect }) => ...
is not possible, but overall, this feels least breaking and least surprising in terms of API.test.each6
({ expect }, arg) => ...
and(arg) => ...
, which might be un-intuitive than having it in the last argument. Also, if Vitest would change the default to be{ context: true }
in the future, then all users (regardless of context/fixture usage) would be impacted by breaking change. Also this would break Jest compatibility.test.each3
boolean
flag?test.each([...])("title", (...) => { ... }, { context: true })
issuecomment-1894155135test.each7
test.each([...], { context: true })
issuecomment-1859974766test.each5
test.each`${0} | ${1}`
TestOption.context
at the 2nd position feat(vitest): "test" accepts options object as the second parameter #5142Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.