-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update vite #5311
Merged
Merged
chore(deps): update vite #5311
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6dcc566
chore(desp): update vite 5.1.4
hi-ogawa 4a30280
test: remove ssr.optimizeDeps hacks for pre Vite 5.1
hi-ogawa bebc007
test(vite-node): robust watch test
hi-ogawa 307df40
chore: fix playwright ci
hi-ogawa cd8dfae
ci: fix playwright
hi-ogawa 9444e11
Merge branch 'main' into chore-vite-5.1.4
hi-ogawa b0de10f
Merge branch 'main' into chore-vite-5.1.4
hi-ogawa 924cf0f
chore: tweak VITE_TEST_WATCHER_DEBUG
hi-ogawa c41bca7
chore: cleanup
hi-ogawa d0f92c5
ci: sequential test
hi-ogawa f087e64
Merge branch 'main' into chore-vite-5.1.4
hi-ogawa e33e558
Revert "ci: sequential test"
hi-ogawa b9a53d5
Merge branch 'main' into chore-vite-5.1.4
hi-ogawa ddecd5c
Merge branch 'main' into chore-vite-5.1.4
hi-ogawa dcc8dda
chore: 5.2.6
hi-ogawa 17aa695
build: remove VITE_TEST_WATCHER_DEBUG on build
hi-ogawa 355ffe3
ci: add NO_VITE_TEST_WATCHER_DEBUG for release build
hi-ogawa fce2087
Merge branch 'main' into chore-vite-5.1.4
hi-ogawa d2ac106
Merge branch 'main' into chore-vite-5.1.4
hi-ogawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add
process.env.VITE_TEST_WATCHER_DEBUG: false
inrollup
config (under a condition like "production" build) so this is removed when bundling?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I can use
process.env.ROLLUP_WATCH
to remove this only on build 17aa695There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this obviously breaks CI since it uses build... Let me think about a different way.