fix(vite-node): fix isValidNodeImport to check "type": "module" first
#5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
changed the title
isValidNodeImport to check type === "module" firstisValidNodeImport to check "type": "module" first
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dunqing
approved these changes
Mar 23, 2024
sheremet-va
approved these changes
Mar 26, 2024
renovate bot
referenced
this pull request
in solid-design-system/solid
Apr 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vite-node](https://togithub.com/vitest-dev/vitest/blob/main/packages/vite-node#readme) ([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vite-node)) | [`1.4.0` -> `1.5.0`](https://renovatebot.com/diffs/npm/vite-node/1.4.0/1.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest (vite-node)</summary> ### [`v1.5.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.4.0...v1.5.0) ##### 🚀 Features - Add configuration for diff truncation - by [@​willieho](https://togithub.com/willieho) in [https://github.com/vitest-dev/vitest/issues/5073](https://togithub.com/vitest-dev/vitest/issues/5073) and [https://github.com/vitest-dev/vitest/issues/5333](https://togithub.com/vitest-dev/vitest/issues/5333) [<samp>(6797b)</samp>](https://togithub.com/vitest-dev/vitest/commit/6797b041) - Remove unrelated noise from diff for toMatchObject() - by [@​geersch](https://togithub.com/geersch) in [https://github.com/vitest-dev/vitest/issues/5364](https://togithub.com/vitest-dev/vitest/issues/5364) [<samp>(99276)</samp>](https://togithub.com/vitest-dev/vitest/commit/99276399) - Allow custom host for --inspect and --inspect-brk - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5509](https://togithub.com/vitest-dev/vitest/issues/5509) [<samp>(61572)</samp>](https://togithub.com/vitest-dev/vitest/commit/6157282c) - **coverage**: V8 to ignore empty lines, comments, types - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5457](https://togithub.com/vitest-dev/vitest/issues/5457) [<samp>(10b89)</samp>](https://togithub.com/vitest-dev/vitest/commit/10b89713) ##### 🐞 Bug Fixes - `describe` calls not taking generic type parameters - by [@​aryaemami59](https://togithub.com/aryaemami59) in [https://github.com/vitest-dev/vitest/issues/5415](https://togithub.com/vitest-dev/vitest/issues/5415) [<samp>(16bac)</samp>](https://togithub.com/vitest-dev/vitest/commit/16bacfab) - Prevent hang when `process` is mocked - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5430](https://togithub.com/vitest-dev/vitest/issues/5430) [<samp>(0ec4d)</samp>](https://togithub.com/vitest-dev/vitest/commit/0ec4d0e0) - Don't check for "node:internal/console/" in console interceptor in case the environment is not Node.js - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(87d36)</samp>](https://togithub.com/vitest-dev/vitest/commit/87d36a7a) - The value received by toMatch should be a string - by [@​btea](https://togithub.com/btea) in [https://github.com/vitest-dev/vitest/issues/5428](https://togithub.com/vitest-dev/vitest/issues/5428) [<samp>(67485)</samp>](https://togithub.com/vitest-dev/vitest/commit/674851ca) - Increase stack trace limit for location, don't hardcode suite position - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5518](https://togithub.com/vitest-dev/vitest/issues/5518) [<samp>(04b23)</samp>](https://togithub.com/vitest-dev/vitest/commit/04b234d1) - **benchmark**: - Run benchmark suites sequentially - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5444](https://togithub.com/vitest-dev/vitest/issues/5444) [<samp>(1f548)</samp>](https://togithub.com/vitest-dev/vitest/commit/1f548340) - Fix benchmark summary of single bench suite - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5489](https://togithub.com/vitest-dev/vitest/issues/5489) [<samp>(db981)</samp>](https://togithub.com/vitest-dev/vitest/commit/db98145f) - Table reporter for non TTY output - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5484](https://togithub.com/vitest-dev/vitest/issues/5484) [<samp>(bea23)</samp>](https://togithub.com/vitest-dev/vitest/commit/bea234b1) - **expect**: - Fix `toHaveBeenNthCalledWith` error message when not called - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5420](https://togithub.com/vitest-dev/vitest/issues/5420) [<samp>(e5253)</samp>](https://togithub.com/vitest-dev/vitest/commit/e5253de4) - **types**: - Pass correct type for suite factory - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5437](https://togithub.com/vitest-dev/vitest/issues/5437) [<samp>(26718)</samp>](https://togithub.com/vitest-dev/vitest/commit/26718eb5) - **utils**: - Fix object diff with getter only property - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5466](https://togithub.com/vitest-dev/vitest/issues/5466) [<samp>(366d9)</samp>](https://togithub.com/vitest-dev/vitest/commit/366d97c3) - **vite-node**: - Fix `isValidNodeImport` to check `"type": "module"` first - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5416](https://togithub.com/vitest-dev/vitest/issues/5416) [<samp>(6fb15)</samp>](https://togithub.com/vitest-dev/vitest/commit/6fb15280) - **vitest**: - Correctly send console events when state changes - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(3463f)</samp>](https://togithub.com/vitest-dev/vitest/commit/3463f9bb) - Initiate FakeTimers on demand - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5450](https://togithub.com/vitest-dev/vitest/issues/5450) [<samp>(e4e93)</samp>](https://togithub.com/vitest-dev/vitest/commit/e4e939ba) - Check unhighlighted code for code frame line limit - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5465](https://togithub.com/vitest-dev/vitest/issues/5465) [<samp>(6ae7e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ae7eaa2) - Correctly filter by parent folder - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5408](https://togithub.com/vitest-dev/vitest/issues/5408) [<samp>(91b06)</samp>](https://togithub.com/vitest-dev/vitest/commit/91b06cce) - Close inspector immediately if run is canceled - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5519](https://togithub.com/vitest-dev/vitest/issues/5519) [<samp>(b8006)</samp>](https://togithub.com/vitest-dev/vitest/commit/b80062d7) - **workspace**: - Set CWD to config directory, allow overriding local .env - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5476](https://togithub.com/vitest-dev/vitest/issues/5476) [<samp>(d4003)</samp>](https://togithub.com/vitest-dev/vitest/commit/d4003882) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.4.0...v1.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone Europe/Berlin, Automerge - "after 10pm every weekday,before 5am every weekday" in timezone Europe/Berlin. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/solid-design-system/solid). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
6 tasks
This was referenced Apr 23, 2024
6 tasks
This was referenced May 21, 2024
This was referenced May 26, 2024
](https://renovatebot.com){kind=link}
github-merge-queue bot
referenced
this pull request
in dotkom/monoweb
Aug 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/ui](https://togithub.com/vitest-dev/vitest/tree/main/packages/ui#readme) ([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/ui)) | [`1.3.1` -> `1.6.0`](https://renovatebot.com/diffs/npm/@vitest%2fui/1.3.1/1.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vitest](https://togithub.com/vitest-dev/vitest) ([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | [`1.3.1` -> `1.6.0`](https://renovatebot.com/diffs/npm/vitest/1.3.1/1.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest (@​vitest/ui)</summary> ### [`v1.6.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.6.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.3...v1.6.0) ##### 🚀 Features - Support standalone mode - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5565](https://togithub.com/vitest-dev/vitest/issues/5565) [<samp>(bdce0)</samp>](https://togithub.com/vitest-dev/vitest/commit/bdce0a29) - Custom "snapshotEnvironment" option - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5449](https://togithub.com/vitest-dev/vitest/issues/5449) [<samp>(30f72)</samp>](https://togithub.com/vitest-dev/vitest/commit/30f728bc) - **benchmark**: Support comparing benchmark result - by [@​hi-ogawa](https://togithub.com/hi-ogawa) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5398](https://togithub.com/vitest-dev/vitest/issues/5398) [<samp>(f8d3d)</samp>](https://togithub.com/vitest-dev/vitest/commit/f8d3d22e) - **browser**: Allow injecting scripts - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5656](https://togithub.com/vitest-dev/vitest/issues/5656) [<samp>(21e58)</samp>](https://togithub.com/vitest-dev/vitest/commit/21e58bd8) - **reporter**: Support `includeConsoleOutput` and `addFileAttribute` in junit - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5659](https://togithub.com/vitest-dev/vitest/issues/5659) [<samp>(2f913)</samp>](https://togithub.com/vitest-dev/vitest/commit/2f913222) - **ui**: Sort items by file name - by [@​btea](https://togithub.com/btea) in [https://github.com/vitest-dev/vitest/issues/5652](https://togithub.com/vitest-dev/vitest/issues/5652) [<samp>(1f726)</samp>](https://togithub.com/vitest-dev/vitest/commit/1f7268fa) ##### 🐞 Bug Fixes - Keep order of arguments for .each in custom task collectors - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5640](https://togithub.com/vitest-dev/vitest/issues/5640) [<samp>(7d57c)</samp>](https://togithub.com/vitest-dev/vitest/commit/7d57c116) - Call `resolveId('vitest')` after `buildStart` - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5646](https://togithub.com/vitest-dev/vitest/issues/5646) [<samp>(f5faf)</samp>](https://togithub.com/vitest-dev/vitest/commit/f5faf423) - Hash the name of the file when caching - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5654](https://togithub.com/vitest-dev/vitest/issues/5654) [<samp>(c9e68)</samp>](https://togithub.com/vitest-dev/vitest/commit/c9e68ced) - Don't panic on empty files in node_modules - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(40c29)</samp>](https://togithub.com/vitest-dev/vitest/commit/40c299fe) - Use `toJSON` for error serialization - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5526](https://togithub.com/vitest-dev/vitest/issues/5526) [<samp>(19a21)</samp>](https://togithub.com/vitest-dev/vitest/commit/19a21e49) - **coverage**: - Exclude `*.test-d.*` by default - by [@​MindfulPol](https://togithub.com/MindfulPol) in [https://github.com/vitest-dev/vitest/issues/5634](https://togithub.com/vitest-dev/vitest/issues/5634) [<samp>(bfe8a)</samp>](https://togithub.com/vitest-dev/vitest/commit/bfe8ad9d) - Apply `vite-node`'s wrapper only to executed files - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5642](https://togithub.com/vitest-dev/vitest/issues/5642) [<samp>(c9883)</samp>](https://togithub.com/vitest-dev/vitest/commit/c9883f3e) - **vm**: - Support network imports - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5610](https://togithub.com/vitest-dev/vitest/issues/5610) [<samp>(103a6)</samp>](https://togithub.com/vitest-dev/vitest/commit/103a6002) ##### 🏎 Performance - Improve performance of forks pool - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5592](https://togithub.com/vitest-dev/vitest/issues/5592) [<samp>(d8304)</samp>](https://togithub.com/vitest-dev/vitest/commit/d8304bb4) - Unnecessary rpc call when coverage is disabled - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5658](https://togithub.com/vitest-dev/vitest/issues/5658) [<samp>(c5712)</samp>](https://togithub.com/vitest-dev/vitest/commit/c571276a) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.3...v1.6.0) ### [`v1.5.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.2...v1.5.3) ##### 🐞 Bug Fixes - Use package.json name for a workspace project if not provided - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5608](https://togithub.com/vitest-dev/vitest/issues/5608) [<samp>(48fba)</samp>](https://togithub.com/vitest-dev/vitest/commit/48fba190) - Backport jest iterable equality within object - by [@​sukovanej](https://togithub.com/sukovanej) in [https://github.com/vitest-dev/vitest/issues/5621](https://togithub.com/vitest-dev/vitest/issues/5621) [<samp>(30e5d)</samp>](https://togithub.com/vitest-dev/vitest/commit/30e5dc1b) - **browser**: Support benchmark - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5622](https://togithub.com/vitest-dev/vitest/issues/5622) [<samp>(becab)</samp>](https://togithub.com/vitest-dev/vitest/commit/becabb5e) - **reporter**: Use default error formatter for JUnit - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5629](https://togithub.com/vitest-dev/vitest/issues/5629) [<samp>(20060)</samp>](https://togithub.com/vitest-dev/vitest/commit/200609cc) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.2...v1.5.3) ### [`v1.5.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.1...v1.5.2) ##### 🐞 Bug Fixes - Check for null before storing in weakmap - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(ce368)</samp>](https://togithub.com/vitest-dev/vitest/commit/ce368457) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.1...v1.5.2) ### [`v1.5.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.0...v1.5.1) ##### 🚀 Features - **api**: `startVitest()` to accept `stdout` and `stdin` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5493](https://togithub.com/vitest-dev/vitest/issues/5493) [<samp>(780b1)</samp>](https://togithub.com/vitest-dev/vitest/commit/780b187f) - This is listed as a feature, but it doesn't increase the minor version because `startVitest` API is experimental and doesn't follow semver. ##### 🐞 Bug Fixes - Close vite servers on all resolved projects - by [@​surc54](https://togithub.com/surc54) in [https://github.com/vitest-dev/vitest/issues/5544](https://togithub.com/vitest-dev/vitest/issues/5544) [<samp>(413ec)</samp>](https://togithub.com/vitest-dev/vitest/commit/413ec5e6) - Fix default `import.meta.env.PROD: false` - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5561](https://togithub.com/vitest-dev/vitest/issues/5561) [<samp>(9c649)</samp>](https://togithub.com/vitest-dev/vitest/commit/9c64967f) - Resolve cwd correctly when initiating projects - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5582](https://togithub.com/vitest-dev/vitest/issues/5582) [<samp>(ec9d7)</samp>](https://togithub.com/vitest-dev/vitest/commit/ec9d7c93) - Always run `onTestFinished` in reverse order - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5598](https://togithub.com/vitest-dev/vitest/issues/5598) [<samp>(23f29)</samp>](https://togithub.com/vitest-dev/vitest/commit/23f29cea) - **browser**: - Disable `fileParallelism` by default on browser pool - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5528](https://togithub.com/vitest-dev/vitest/issues/5528) [<samp>(5c69f)</samp>](https://togithub.com/vitest-dev/vitest/commit/5c69f3f5) - Dispose tester iframe on done - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5595](https://togithub.com/vitest-dev/vitest/issues/5595) [<samp>(b2135)</samp>](https://togithub.com/vitest-dev/vitest/commit/b2135710) - **coverage**: - Fix bundling of `v8-to-istanbul` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5549](https://togithub.com/vitest-dev/vitest/issues/5549) [<samp>(df6a4)</samp>](https://togithub.com/vitest-dev/vitest/commit/df6a4328) - Prevent crash when `cleanOnRerun` is disabled - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5540](https://togithub.com/vitest-dev/vitest/issues/5540) [<samp>(ea3c1)</samp>](https://togithub.com/vitest-dev/vitest/commit/ea3c16e4) - `thresholds` to compare files relative to root - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5574](https://togithub.com/vitest-dev/vitest/issues/5574) [<samp>(80265)</samp>](https://togithub.com/vitest-dev/vitest/commit/80265b40) - **expect**: - Fix `toEqual` and `toMatchObject` with circular references - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5535](https://togithub.com/vitest-dev/vitest/issues/5535) [<samp>(9e641)</samp>](https://togithub.com/vitest-dev/vitest/commit/9e6417c9) - **vitest**: - Fix false positive file filter match with leading slash - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5578](https://togithub.com/vitest-dev/vitest/issues/5578) [<samp>(316eb)</samp>](https://togithub.com/vitest-dev/vitest/commit/316eb739) - Watch the output directory correctly - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5584](https://togithub.com/vitest-dev/vitest/issues/5584) [<samp>(e40f9)</samp>](https://togithub.com/vitest-dev/vitest/commit/e40f9924) - StubEnv casts boolean on PROD/SSR/DEV - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5590](https://togithub.com/vitest-dev/vitest/issues/5590) [<samp>(4da88)</samp>](https://togithub.com/vitest-dev/vitest/commit/4da88045) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.0...v1.5.1) ### [`v1.5.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.4.0...v1.5.0) ##### 🚀 Features - Add configuration for diff truncation - by [@​willieho](https://togithub.com/willieho) in [https://github.com/vitest-dev/vitest/issues/5073](https://togithub.com/vitest-dev/vitest/issues/5073) and [https://github.com/vitest-dev/vitest/issues/5333](https://togithub.com/vitest-dev/vitest/issues/5333) [<samp>(6797b)</samp>](https://togithub.com/vitest-dev/vitest/commit/6797b041) - Remove unrelated noise from diff for toMatchObject() - by [@​geersch](https://togithub.com/geersch) in [https://github.com/vitest-dev/vitest/issues/5364](https://togithub.com/vitest-dev/vitest/issues/5364) [<samp>(99276)</samp>](https://togithub.com/vitest-dev/vitest/commit/99276399) - Allow custom host for --inspect and --inspect-brk - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5509](https://togithub.com/vitest-dev/vitest/issues/5509) [<samp>(61572)</samp>](https://togithub.com/vitest-dev/vitest/commit/6157282c) - **coverage**: V8 to ignore empty lines, comments, types - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5457](https://togithub.com/vitest-dev/vitest/issues/5457) [<samp>(10b89)</samp>](https://togithub.com/vitest-dev/vitest/commit/10b89713) ##### 🐞 Bug Fixes - `describe` calls not taking generic type parameters - by [@​aryaemami59](https://togithub.com/aryaemami59) in [https://github.com/vitest-dev/vitest/issues/5415](https://togithub.com/vitest-dev/vitest/issues/5415) [<samp>(16bac)</samp>](https://togithub.com/vitest-dev/vitest/commit/16bacfab) - Prevent hang when `process` is mocked - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5430](https://togithub.com/vitest-dev/vitest/issues/5430) [<samp>(0ec4d)</samp>](https://togithub.com/vitest-dev/vitest/commit/0ec4d0e0) - Don't check for "node:internal/console/" in console interceptor in case the environment is not Node.js - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(87d36)</samp>](https://togithub.com/vitest-dev/vitest/commit/87d36a7a) - The value received by toMatch should be a string - by [@​btea](https://togithub.com/btea) in [https://github.com/vitest-dev/vitest/issues/5428](https://togithub.com/vitest-dev/vitest/issues/5428) [<samp>(67485)</samp>](https://togithub.com/vitest-dev/vitest/commit/674851ca) - Increase stack trace limit for location, don't hardcode suite position - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5518](https://togithub.com/vitest-dev/vitest/issues/5518) [<samp>(04b23)</samp>](https://togithub.com/vitest-dev/vitest/commit/04b234d1) - **benchmark**: - Run benchmark suites sequentially - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5444](https://togithub.com/vitest-dev/vitest/issues/5444) [<samp>(1f548)</samp>](https://togithub.com/vitest-dev/vitest/commit/1f548340) - Fix benchmark summary of single bench suite - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5489](https://togithub.com/vitest-dev/vitest/issues/5489) [<samp>(db981)</samp>](https://togithub.com/vitest-dev/vitest/commit/db98145f) - Table reporter for non TTY output - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5484](https://togithub.com/vitest-dev/vitest/issues/5484) [<samp>(bea23)</samp>](https://togithub.com/vitest-dev/vitest/commit/bea234b1) - **expect**: - Fix `toHaveBeenNthCalledWith` error message when not called - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5420](https://togithub.com/vitest-dev/vitest/issues/5420) [<samp>(e5253)</samp>](https://togithub.com/vitest-dev/vitest/commit/e5253de4) - **types**: - Pass correct type for suite factory - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5437](https://togithub.com/vitest-dev/vitest/issues/5437) [<samp>(26718)</samp>](https://togithub.com/vitest-dev/vitest/commit/26718eb5) - **utils**: - Fix object diff with getter only property - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5466](https://togithub.com/vitest-dev/vitest/issues/5466) [<samp>(366d9)</samp>](https://togithub.com/vitest-dev/vitest/commit/366d97c3) - **vite-node**: - Fix `isValidNodeImport` to check `"type": "module"` first - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5416](https://togithub.com/vitest-dev/vitest/issues/5416) [<samp>(6fb15)</samp>](https://togithub.com/vitest-dev/vitest/commit/6fb15280) - **vitest**: - Correctly send console events when state changes - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(3463f)</samp>](https://togithub.com/vitest-dev/vitest/commit/3463f9bb) - Initiate FakeTimers on demand - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5450](https://togithub.com/vitest-dev/vitest/issues/5450) [<samp>(e4e93)</samp>](https://togithub.com/vitest-dev/vitest/commit/e4e939ba) - Check unhighlighted code for code frame line limit - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5465](https://togithub.com/vitest-dev/vitest/issues/5465) [<samp>(6ae7e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ae7eaa2) - Correctly filter by parent folder - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5408](https://togithub.com/vitest-dev/vitest/issues/5408) [<samp>(91b06)</samp>](https://togithub.com/vitest-dev/vitest/commit/91b06cce) - Close inspector immediately if run is canceled - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5519](https://togithub.com/vitest-dev/vitest/issues/5519) [<samp>(b8006)</samp>](https://togithub.com/vitest-dev/vitest/commit/b80062d7) - **workspace**: - Set CWD to config directory, allow overriding local .env - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5476](https://togithub.com/vitest-dev/vitest/issues/5476) [<samp>(d4003)</samp>](https://togithub.com/vitest-dev/vitest/commit/d4003882) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.4.0...v1.5.0) ### [`v1.4.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.4.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.3.1...v1.4.0) ##### 🚀 Features - Throw error when using snapshot assertion with `not` - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5294](https://togithub.com/vitest-dev/vitest/issues/5294) [<samp>(b9d37)</samp>](https://togithub.com/vitest-dev/vitest/commit/b9d378f5) - Add a flag to include test location in tasks - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5342](https://togithub.com/vitest-dev/vitest/issues/5342) [<samp>(d627e)</samp>](https://togithub.com/vitest-dev/vitest/commit/d627e209) - **cli**: - Support wildcards in `--project` option - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5295](https://togithub.com/vitest-dev/vitest/issues/5295) [<samp>(201bd)</samp>](https://togithub.com/vitest-dev/vitest/commit/201bd067) - **config**: - Add `shuffle.files` and `shuffle.tests` options - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5281](https://togithub.com/vitest-dev/vitest/issues/5281) [<samp>(356db)</samp>](https://togithub.com/vitest-dev/vitest/commit/356db87b) - Deprecate `cache.dir` option - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5229](https://togithub.com/vitest-dev/vitest/issues/5229) [<samp>(d7e8b)</samp>](https://togithub.com/vitest-dev/vitest/commit/d7e8b53e) - **coverage**: - Support `--changed` option - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5314](https://togithub.com/vitest-dev/vitest/issues/5314) [<samp>(600b4)</samp>](https://togithub.com/vitest-dev/vitest/commit/600b44d6) - **vitest**: - Support `clearScreen` cli flag - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5241](https://togithub.com/vitest-dev/vitest/issues/5241) [<samp>(e1735)</samp>](https://togithub.com/vitest-dev/vitest/commit/e1735fb6) ##### 🐞 Bug Fixes - Repeatable `--project` option - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5265](https://togithub.com/vitest-dev/vitest/issues/5265) [<samp>(d1a06)</samp>](https://togithub.com/vitest-dev/vitest/commit/d1a06730) - `--inspect-brk` to pause before execution - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5355](https://togithub.com/vitest-dev/vitest/issues/5355) [<samp>(e77c5)</samp>](https://togithub.com/vitest-dev/vitest/commit/e77c553f) - Correct locations in test.each tasks - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(4f6e3)</samp>](https://togithub.com/vitest-dev/vitest/commit/4f6e39c1) - **api**: - Use resolvedUrls from devserver - by [@​saitonakamura](https://togithub.com/saitonakamura) and [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5289](https://togithub.com/vitest-dev/vitest/issues/5289) [<samp>(2fef5)</samp>](https://togithub.com/vitest-dev/vitest/commit/2fef5a7e) - **browser**: - Add `magic-string` to `optimizeDeps.include` - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5278](https://togithub.com/vitest-dev/vitest/issues/5278) [<samp>(8f04e)</samp>](https://togithub.com/vitest-dev/vitest/commit/8f04e798) - **coverage**: - Expensive regexp hangs v8 report generation - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5259](https://togithub.com/vitest-dev/vitest/issues/5259) [<samp>(d68a7)</samp>](https://togithub.com/vitest-dev/vitest/commit/d68a7390) - V8 to ignore type-only files - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5328](https://togithub.com/vitest-dev/vitest/issues/5328) [<samp>(c3eb8)</samp>](https://togithub.com/vitest-dev/vitest/commit/c3eb8deb) - Respect source maps of pre-transpiled sources - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5367](https://togithub.com/vitest-dev/vitest/issues/5367) [<samp>(6eda4)</samp>](https://togithub.com/vitest-dev/vitest/commit/6eda473f) - Prevent `reportsDirectory` from removing user's project - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5376](https://togithub.com/vitest-dev/vitest/issues/5376) [<samp>(07ec3)</samp>](https://togithub.com/vitest-dev/vitest/commit/07ec3779) - **expect**: - Show diff on `toContain/toMatch` assertion error - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5267](https://togithub.com/vitest-dev/vitest/issues/5267) [<samp>(8ee59)</samp>](https://togithub.com/vitest-dev/vitest/commit/8ee59f0d) - **forks**: - Wrap `defines` to support `undefined` values - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5284](https://togithub.com/vitest-dev/vitest/issues/5284) [<samp>(5b58b)</samp>](https://togithub.com/vitest-dev/vitest/commit/5b58b399) - **typecheck**: - Update get-tsconfig 4.7.3 to fix false circularity error - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5384](https://togithub.com/vitest-dev/vitest/issues/5384) [<samp>(bdc37)</samp>](https://togithub.com/vitest-dev/vitest/commit/bdc371ee) - **ui**: - Escape html in error diff - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5325](https://togithub.com/vitest-dev/vitest/issues/5325) [<samp>(ab60b)</samp>](https://togithub.com/vitest-dev/vitest/commit/ab60bf8d) - **vitest**: - Loosen `onConsoleLog` return type - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5337](https://togithub.com/vitest-dev/vitest/issues/5337) [<samp>(6d1b1)</samp>](https://togithub.com/vitest-dev/vitest/commit/6d1b1451) - Ensure restoring terminal cursor on close - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5292](https://togithub.com/vitest-dev/vitest/issues/5292) [<samp>(0bea2)</samp>](https://togithub.com/vitest-dev/vitest/commit/0bea2247) - Ignore timeout on websocket reporter rpc - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(38119)</samp>](https://togithub.com/vitest-dev/vitest/commit/38119b75) - Correctly override api with --no-api flag - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5386](https://togithub.com/vitest-dev/vitest/issues/5386) [<samp>(51d1d)</samp>](https://togithub.com/vitest-dev/vitest/commit/51d1d472) - Logs in `beforeAll` and `afterAll` - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5288](https://togithub.com/vitest-dev/vitest/issues/5288) [<samp>(ce5ca)</samp>](https://togithub.com/vitest-dev/vitest/commit/ce5ca6bf) - **workspace**: - Throw error when browser mode and `@vitest/coverage-v8` are used - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5250](https://togithub.com/vitest-dev/vitest/issues/5250) [<samp>(29f98)</samp>](https://togithub.com/vitest-dev/vitest/commit/29f98cd3) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.3.1...v1.4.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/dotkom/monoweb). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in #5404 (comment), current
shouldExternalizeandisValidNodeImportheuristics don't seem optimal.By flipping the condition of
"type": "module"check and/esm?/.test(id)(which is whatmllyhas been doing), I think this will save legitimate ESM from inlined due to the file name having.../esm/...like the case ofwagmihttps://publint.dev/wagmi@2.5.11.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.