Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove --segfault-retry #5514

Merged
merged 2 commits into from
May 6, 2024
Merged

feat!: remove --segfault-retry #5514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfaf030
feat: remove --segfault-retry
sheremet-va Apr 9, 2024
7e4f1d3
chore: remove VITEST_SEGFAULT_RETRY: 3
sheremet-va May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ concurrency:
cancel-in-progress: true

env:
VITEST_SEGFAULT_RETRY: 3
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/.cache/ms-playwright
CYPRESS_CACHE_FOLDER: ${{ github.workspace }}/.cache/Cypress

Expand Down
1 change: 0 additions & 1 deletion packages/vitest/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const entries = {
'path': 'src/paths.ts',
'index': 'src/index.ts',
'cli': 'src/node/cli.ts',
'cli-wrapper': 'src/node/cli/cli-wrapper.ts',
'node': 'src/node.ts',
'suite': 'src/suite.ts',
'browser': 'src/browser.ts',
Expand Down
147 changes: 0 additions & 147 deletions packages/vitest/src/node/cli/cli-wrapper.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/vitest/vitest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/usr/bin/env node
import './dist/cli-wrapper.js'
import './dist/cli.js'
12 changes: 1 addition & 11 deletions test/config/test/exec-args.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
import { afterAll, beforeAll, expect, test } from 'vitest'
import { expect, test } from 'vitest'
import { execa } from 'execa'
import { runVitest } from '../../test-utils'

// VITEST_SEGFAULT_RETRY messes with the node flags, as can be seen in packages/vitest/src/node/cli-wrapper.ts
// so here we remove it to make sure the tests are not affected by it
const ORIGIN_VITEST_SEGFAULT_RETRY = process.env.VITEST_SEGFAULT_RETRY
beforeAll(() => {
delete process.env.VITEST_SEGFAULT_RETRY
})
afterAll(() => {
process.env.VITEST_SEGFAULT_RETRY = ORIGIN_VITEST_SEGFAULT_RETRY
})

test.each([
{ pool: 'forks', execArgv: ['--hash-seed=1', '--random-seed=1', '--no-opt'] },
{ pool: 'threads', execArgv: ['--inspect-brk'] },
Expand Down
Loading