Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): clean up empty coverage reports directory #5731

Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented May 15, 2024

Description

If built-in or third party coverage reporter doesn't emit any files in reports directory, remove that directory after coverage reporting.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio changed the title fix: clean up empty coverage reports directory fix(coverage): clean up empty coverage reports directory May 15, 2024
@AriPerkkio AriPerkkio force-pushed the fix/coverage-clean-empty-reports-dir branch from c65b659 to ff48204 Compare May 15, 2024 17:08
@AriPerkkio AriPerkkio marked this pull request as ready for review May 15, 2024 17:11
@sheremet-va sheremet-va merged commit c469c74 into vitest-dev:main May 17, 2024
16 checks passed
@AriPerkkio AriPerkkio deleted the fix/coverage-clean-empty-reports-dir branch May 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text reporter still creates an empty coverage folder
2 participants