fix(runner): Ensure test.each print -0 and -NaN properly #5806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #5744
Prev PR(closed)
This bug fix ensures that when using test.each, the descriptive text for
-0
and-NaN
is correctly printed as-0
and-NaN
instead of0
andNaN
.Context
The logic to resolve this issue was moved from format (utils) to the
formatTitle(runner.ts)
function. The function now checks if the value of %f in the template is -0 or -NaN using an ArrayBuffer and formats it appropriately.However, despite various attempts, it was not possible to write a proper regression test for the formatTitle function in suite.ts without exporting the function. Additionally, no test suite for formatTitle was found.
To get feedback on the test, I am creating this PR with the following considerations:
formatTitle
for testing purposes (which I believe might be a bit risky).Tests
check for single values: ✓
check for multiple values(2): ✓
check for multiple values(3): ✓
check for multiple values(4): ✓
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.