feat(browser): add browser iframe mouse interaction #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
commented
Jun 1, 2024
sheremet-va
requested changes
Jun 1, 2024
| } | ||
|
|
||
| export function registerResizingListener(listener: ResizingListener) { | ||
| inject<(listener: ResizingListener) => void>(resizingSymbol)?.(listener) |
There was a problem hiding this comment.
isn't this just a ResizingListener?
There was a problem hiding this comment.
I'm going to configure it globally (like navigation conposable), vitest ui is just a spa, dont need inject/provide
There was a problem hiding this comment.
This listener is the callback called from the index.vue
There was a problem hiding this comment.
I mean the type is repeated, you already defined it on the top
| iframe.setAttribute('allowfullscreen', 'true') | ||
| iframe.setAttribute('allow', 'clipboard-write;') | ||
|
|
||
| iframes.set(file, iframe) | ||
| container.className = 'scrolls' |
There was a problem hiding this comment.
should probably move that to line 190
sheremet-va
approved these changes
Jun 2, 2024
1 task
This was referenced Sep 10, 2024
This was referenced Sep 23, 2024
This was referenced Oct 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
supersedes #5813
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.