Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update running todo tests inside todo suites (each) #5939

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Jun 20, 2024

Description

Todo tests inside todo suites (each) not being reported and so the running spinner in the ui: this PR updates the mode to todo for any tests running inside any test suite (will run at the end).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@userquin userquin marked this pull request as draft June 20, 2024 15:06
@userquin userquin marked this pull request as ready for review June 20, 2024 15:33
@userquin userquin changed the title fix(ui): update running todo tests inside todo suites fix(ui): update running todo tests inside todo suites (each) Jun 20, 2024
@userquin userquin merged commit 63ae10b into main Jun 20, 2024
16 checks passed
@userquin userquin deleted the userquin/fix-todo-tests-mode-inside-todo-suites branch June 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants