Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve assets imported with require #6159

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jul 18, 2024

Description

This PR makes it so require('*.png') and other asset types supported by Vite, don't fail in Node.js

By default, we assume the same hevaviour that Vite has: require('.png') returns a filepath

Closes #3809

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va changed the title feat: resolve assets imported with require fix: resolve assets imported with require Jul 18, 2024
@sheremet-va sheremet-va merged commit 807a2cb into vitest-dev:main Jul 18, 2024
13 checks passed
@sheremet-va sheremet-va deleted the fix/dont-fail-require-asset branch July 18, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant