-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Extend existing list command to output only a list of file names #6392
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation seems a bit pointless because you can do the same yourself on vitest list
result.
What we need is to not collect tests at all to make this very fast. This line should just not be called:
vitest/packages/vitest/src/node/core.ts
Line 369 in 95f0203
await this.collectFiles(files) |
OK, async listFiles(filters?: string[]) {
const files = await this.filterTestsBySource(
await this.globTestFiles(filters),
)
return files
} in the vitest class and checking the option in cac.ts:collect() and calling it will do the job ? |
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
Thanks! |
Description
Extend existing list command to output only a list of file names
closes #6374
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
introduces breaking changes without a discussion, PR might be closed.
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.