Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: spy.mockReset changes #6426

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Lordfirespeed
Copy link

@Lordfirespeed Lordfirespeed commented Aug 29, 2024

Description

Warning

This is a breaking change.

See #6378, #6308

This PR changes the behaviour of mockReset to the proposed behaviour of mockRevert in #6378.

That is, spy.mockReset() will reset the inner implementation of spy to its original.

Previously, spy.mockReset would reset the inner implementation of spy to () => undefined.

PR Checklist

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@Lordfirespeed Lordfirespeed changed the title Feat/spy.mockReset changes Feat!/spy.mockReset changes Aug 29, 2024
@Lordfirespeed Lordfirespeed changed the title Feat!/spy.mockReset changes Feat!: spy.mockReset changes Aug 29, 2024
@Lordfirespeed Lordfirespeed changed the title Feat!: spy.mockReset changes feat!: spy.mockReset changes Aug 29, 2024
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d8f5d9d
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66d0cf6f80487f0008bd994e
😎 Deploy Preview https://deploy-preview-6426--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va added this to the 3.0.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants