Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spy)!: spyOn reuses mock if method is already spyed on #6464

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Sep 9, 2024

Description

Fixes #6419
Fixes #6465

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 7823a4e
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66dea5f99aed390008de78f6
😎 Deploy Preview https://deploy-preview-6464--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 164cb70
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6752c4241d29430008ec990a
😎 Deploy Preview https://deploy-preview-6464--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va added this to the 3.0.0 milestone Nov 7, 2024
@sheremet-va sheremet-va changed the title fix(spy): spyOn reuses mock if method is already spyed on fix(spy)!: spyOn reuses mock if method is already spyed on Nov 7, 2024
@sheremet-va
Copy link
Member Author

@hi-ogawa need heelp

@hi-ogawa
Copy link
Contributor

hi-ogawa commented Dec 6, 2024

I don't think we need to change automocker since class instance's const original = this[key] is not an owned property, so spyOn can ignore it and add the new spy as owned prop.
This means that reusing spyOn only happens for owned prop, but that behavior is probably reasonable.

@sheremet-va sheremet-va merged commit b3e43d0 into vitest-dev:main Dec 9, 2024
17 checks passed
@sheremet-va sheremet-va deleted the fix/reuse-mock branch December 9, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants