Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Make clicking on a test in the UI open the report section and scroll to the test failure if applicable #6900

Conversation

jacoberdman2147
Copy link
Contributor

@jacoberdman2147 jacoberdman2147 commented Nov 12, 2024

Description

This addresses #6747

This PR makes it so that clicking on a test in the UI will open the report section and scroll to the test failure within it if one exists. This also improves the functionality a bit where before if you clicked the icon on a test suite to view the report, it wouldn't actually take you there. This was kind of my take on the issue so I'm open to any suggestions on how this should work (also this is my first time ever working with Vue so hopefully I didn't do anything weird there).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@jacoberdman2147
Copy link
Contributor Author

For the documentation checkbox, is there any place where I'd document this or is it good to go on that front?

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f6e9c2b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6736520f7ca358000805b86e
😎 Deploy Preview https://deploy-preview-6900--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member

For the documentation checkbox, is there any place where I'd document this or is it good to go on that front?

It should be fine as is

@sheremet-va sheremet-va merged commit 1bf27f0 into vitest-dev:main Dec 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants