Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): correct coverage when isolate: false is used #6957

Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Nov 24, 2024

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 73e2958
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6756a6177ab09400086759b4
😎 Deploy Preview https://deploy-preview-6957--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 24, 2024

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@6957

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@6957

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@6957

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@6957

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@6957

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@6957

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@6957

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@6957

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@6957

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@6957

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@6957

vite-node

npm i https://pkg.pr.new/vite-node@6957

vitest

npm i https://pkg.pr.new/vitest@6957

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@6957

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@6957

commit: c89f42b

@AriPerkkio AriPerkkio force-pushed the fix/coverage-isolate-false-v8 branch from 62260c1 to f563f7e Compare November 24, 2024 09:00
@AriPerkkio AriPerkkio force-pushed the fix/coverage-isolate-false-v8 branch from ef24cc7 to 3bb8f66 Compare December 9, 2024 08:55
@AriPerkkio AriPerkkio changed the title fix(coverage): isolate: false with v8 provider fix(coverage): correct coverage when isolate: false is used Dec 9, 2024
@AriPerkkio
Copy link
Member Author

AriPerkkio commented Dec 9, 2024

/ecosystem-ci run

(interested in vitest-coverage-large and aria-live-capture)

@vitest-ecosystem-ci
Copy link

vitest-ecosystem-ci bot commented Dec 9, 2024

📝 Ran ecosystem CI: Open

suite result
aria-live-capture ✅ success
nuxt ❌ failure
nuxt-test-utils ❌ failure
elk ✅ success
effect ✅ success
lerna-lite ✅ success
zustand ✅ success
vue ✅ success
vite ✅ success
vitest-vscode ❌ failure
vitest-sonar-reporter ❌ failure
vitest-github-actions-reporter ❌ failure
vitest-browser-simple ✅ success
vitest-browser-examples ❌ failure
vitest-coverage-large ✅ success
vitest-reporters-large ✅ success
vitest-benchmark-large ✅ success

@AriPerkkio AriPerkkio marked this pull request as ready for review December 9, 2024 09:36
packages/coverage-v8/src/browser.ts Outdated Show resolved Hide resolved
packages/coverage-istanbul/src/index.ts Outdated Show resolved Hide resolved
@AriPerkkio AriPerkkio merged commit 426ce6d into vitest-dev:main Dec 9, 2024
13 of 18 checks passed
@AriPerkkio AriPerkkio deleted the fix/coverage-isolate-false-v8 branch December 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong coverage when using isolate: false
2 participants