-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use tinyglobby
instead of fast-glob
in Vitest
#7504
Conversation
This reverts commit 70baaaa.
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc9ff1a
to
5df1978
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it Storybook whose tests failed after this change previously, @sheremet-va? They are not in the ecosystem-ci so we'll need preview release for them to try.
@vitest/browser
@vitest/coverage-istanbul
@vitest/expect
@vitest/pretty-format
@vitest/mocker
@vitest/coverage-v8
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
cc. @JReinhold |
Looks good in Storybook, everything works! To be safe, I also tested with Vitest 2.1.0 (the original For full context, in Storybook's CI we have a lot of stories/tests symlinked into ecosystem directories, and they wouldn't get picked up by the faulty versions of Vitest, but they are with this version. |
This reverts commit 70baaaa.
Description
Discussed here: #6688 (comment)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.