Skip to content

fix: avoid crashing on process.versions stub #9174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 1 commit into from
Dec 5, 2025
Merged

fix: avoid crashing on process.versions stub #9174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/vitest/src/utils/modules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ const BUN_BUILTIN_NAMESPACE = 'bun:'
// Some runtimes like Bun injects namespaced modules here, which is not a node builtin
const nodeBuiltins = builtinModules.filter(id => !id.includes(':'))

const { bun: isBun, deno: isDeno } = process.versions

// TODO: Use `isBuiltin` from `node:module`, but Deno doesn't support it
export function isBuiltin(id: string): boolean {
if (process.versions.deno && id.startsWith(NPM_BUILTIN_NAMESPACE)) {
if (isDeno && id.startsWith(NPM_BUILTIN_NAMESPACE)) {
return true
}
if (process.versions.bun && id.startsWith(BUN_BUILTIN_NAMESPACE)) {
if (isBun && id.startsWith(BUN_BUILTIN_NAMESPACE)) {
return true
}
return isNodeBuiltin(id)
Expand Down Expand Up @@ -47,7 +49,7 @@ export function toBuiltin(id: string): string {
) {
return id
}
if (process.versions.deno || process.versions.bun) {
if (isDeno || isBun) {
return id
}
return `node:${id}`
Expand Down
4 changes: 4 additions & 0 deletions test/core/test/stubbed-process.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ vi.stubGlobal('process', { badMock: true })
it('should not hang', () => {
expect(1).toBe(1)
})

it('should not crash (#9173)', async () => {
await import('./fixtures/increment')
})
Loading