test: skip test with rolldown inside vmThreads + update snapshot#9415
Merged
sheremet-va merged 17 commits intovitest-dev:mainfrom Jan 13, 2026
Merged
test: skip test with rolldown inside vmThreads + update snapshot#9415sheremet-va merged 17 commits intovitest-dev:mainfrom
sheremet-va merged 17 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
…to 01-09-chore_test_rolldown_ci
Add scope tracking for ClassDeclaration and ClassExpression to prevent incorrect import binding replacement when a class shadows an imported name. - ClassDeclaration: add name to parent block scope (like FunctionDeclaration) - ClassExpression: add name to its own scope (visible only inside class body) This bug was hidden in vite v7 because esbuild renamed shadowing classes. With vite v8/oxc preserving original names, the bug became visible. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
7 tasks
hi-ogawa
changed the title
hi-ogawa
force-pushed
the
01-09-chore_test_rolldown_ci
branch
from
6e80689 to
0fdf86d
Compare
hi-ogawa
changed the title
sheremet-va
requested changes
Jan 13, 2026
test/core/test/cli-test.test.ts
Outdated
| test('clearScreen', async (ctx) => { | ||
| // skip vm since rolldown native modules break due to RegExp instance | ||
| // https://github.com/vitest-dev/vitest/issues/8754#issuecomment-3727583957 | ||
| const vite = await import('vite') |
Member
There was a problem hiding this comment.
You can get rolldownVersion from 'vitest/node'
sheremet-va
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.