Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debugging not hitting breakpoints #230

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

ffMathy
Copy link
Collaborator

@ffMathy ffMathy commented Feb 17, 2024

Breakpoints are not hit because VS Code is looking at the wrong directory for output files. In addition, there was an issue with the --api.host being set twice for the basic configuration.

@MilanKovacic
Copy link
Collaborator

Fixes #227.

@ffMathy ffMathy mentioned this pull request Feb 17, 2024
@ffMathy
Copy link
Collaborator Author

ffMathy commented Feb 17, 2024

An alternative fix could be to modify the tsup CLI call to be explicit about the output directory, thus respecting the out directory still. Up to you.

Copy link
Collaborator

@MilanKovacic MilanKovacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants